Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions lib/MessageDecoder.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,4 +61,30 @@ describe('MessageDecoder', () => {
expect(decodeResult.message.label).toBe('H1');
expect(decodeResult.formatted.items.length).toBe(5);
});

test('preserves default fallback result when no plugin decodes', () => {
const message = {
label: '44',
text: 'GARBAGE TEXT THAT SHOULD NOT MATCH',
};

const decodeResult = decoder.decode(message);

expect(decodeResult.decoded).toBe(false);
expect(decodeResult.error).toBe('No known decoder plugin for this message');
expect(decodeResult.decoder).toEqual({
name: 'none',
type: 'none',
decodeLevel: 'none',
});
expect(decodeResult.message).toBe(message);
expect(decodeResult.remaining).toEqual({
text: message.text,
});
expect(decodeResult.raw).toEqual({});
expect(decodeResult.formatted).toEqual({
description: 'Not Decoded',
items: [],
});
});
});
5 changes: 3 additions & 2 deletions lib/MessageDecoder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,9 @@ export class MessageDecoder {

for (let i = 0; i < usablePlugins.length; i++) {
const plugin = usablePlugins[i];
result = plugin.decode(message, options);
if (result.decoded) {
const pluginResult = plugin.decode(message, options);
if (pluginResult.decoded) {
result = pluginResult;
break;
}
}
Expand Down