Preserve default fallback result when no decoder plugin matches#440
Draft
Copilot wants to merge 2 commits into
Draft
Preserve default fallback result when no decoder plugin matches#440Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix MessageDecoder.decode to preserve default failure result
Preserve default fallback result when no decoder plugin matches
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MessageDecoder.decode()initialized a useful fallback result for unmatched messages, but then replaced it with each plugin's unsuccessful return. As a result, callers could receive the last plugin's partial "unknown" response instead of the intended top-level failure payload.Decoder fallback semantics
DecodeResultas the return value unless a plugin actually decodes the message.error: 'No known decoder plugin for this message'decoder: { name: 'none', type: 'none', decodeLevel: 'none' }messageremaining.textformatted.description: 'Not Decoded'Regression coverage
MessageDecodertest for a registered label (44) with garbage payload that no plugin can decode.Behavioral change