Skip to content

Fix DateTimeUtils UTC string semantics and remove deprecated substr usage #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Fix DateTimeUtils UTC string semantics and remove deprecated substr usage #439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2800f86
Initial plan
Copilot May 28, 2026
6d31a3f
fix: return UTC time string in DateTimeUtils.UTCToString
Copilot May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions lib/DateTimeUtils.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import { DateTimeUtils } from './DateTimeUtils';

describe('DateTimeUtils', () => {
test('UTCToString returns a UTC HH:MM:SS string', () => {
expect(DateTimeUtils.UTCToString('1530')).toBe('15:30:00');
});

test('UTCDateTimeToString supports both HHMM and HHMMSS', () => {
expect(DateTimeUtils.UTCDateTimeToString('010124', '1530')).toContain(
'15:30:00 GMT',
);
expect(DateTimeUtils.UTCDateTimeToString('010124', '153045')).toContain(
'15:30:45 GMT',
);
});
});
24 changes: 14 additions & 10 deletions lib/DateTimeUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,29 +2,33 @@ export class DateTimeUtils {
// Expects a four digit UTC time string (HHMM)
public static UTCToString(UTCString: string) {
let utcDate = new Date();
utcDate.setUTCHours(+UTCString.substr(0, 2), +UTCString.substr(2, 2), 0);
return utcDate.toTimeString();
utcDate.setUTCHours(
+UTCString.substring(0, 2),
+UTCString.substring(2, 4),
0,
);
return utcDate.toISOString().substring(11, 19);
}

// Expects a six digit date string and a four digit UTC time string
// (DDMMYY) (HHMM)
public static UTCDateTimeToString(dateString: string, timeString: string) {
let utcDate = new Date();
utcDate.setUTCDate(+dateString.substr(0, 2));
utcDate.setUTCMonth(+dateString.substr(2, 2));
utcDate.setUTCDate(+dateString.substring(0, 2));
utcDate.setUTCMonth(+dateString.substring(2, 4));
if (dateString.length === 6) {
utcDate.setUTCFullYear(2000 + +dateString.substr(4, 2));
utcDate.setUTCFullYear(2000 + +dateString.substring(4, 6));
}
if (timeString.length === 6) {
utcDate.setUTCHours(
+timeString.substr(0, 2),
+timeString.substr(2, 2),
+timeString.substr(4, 2),
+timeString.substring(0, 2),
+timeString.substring(2, 4),
+timeString.substring(4, 6),
);
} else {
utcDate.setUTCHours(
+timeString.substr(0, 2),
+timeString.substr(2, 2),
+timeString.substring(0, 2),
+timeString.substring(2, 4),
0,
);
}
Expand Down