Fix DateTimeUtils UTC string semantics and remove deprecated substr usage#439
Draft
Copilot wants to merge 2 commits into
Draft
Fix DateTimeUtils UTC string semantics and remove deprecated substr usage#439Copilot wants to merge 2 commits into
substr usage#439Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix DateTimeUtils.UTCToString to return UTC time
Fix DateTimeUtils UTC string semantics and remove deprecated May 28, 2026
substr usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DateTimeUtils.UTCToStringwas returning local-time output (toTimeString()), which contradicted its UTC naming and made output timezone-dependent across environments. The DateTimeUtils UTC parsing methods also used legacysubstr().UTC output correctness
UTCToStringnow returns a UTC-stableHH:MM:SSvalue derived fromtoISOString()instead of local-timetoTimeString().Deprecated API cleanup
substr()withsubstring()in:UTCToStringUTCDateTimeToStringFocused coverage for UTC formatting paths
lib/DateTimeUtils.test.tsto cover:UTCToString('1530') -> '15:30:00'UTCDateTimeToStringhandling for bothHHMMandHHMMSS