Skip to content

feat: Update aria hideoutside to work with shadow doms#9607

Open
snowystinger wants to merge 4 commits intomainfrom
update-ariaHideOutside-to-work-with-shadow-doms
Open

feat: Update aria hideoutside to work with shadow doms#9607
snowystinger wants to merge 4 commits intomainfrom
update-ariaHideOutside-to-work-with-shadow-doms

Conversation

@snowystinger
Copy link
Member

Closes #6133
Replaces #6160 and the changes that are in #9369

Tests mostly taken from #6160

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Unit tests should cover it. The code path only activates if someone has the shadowdom flag turned on.

🧢 Your Project:

"react-test-renderer": "19.1.0",
"@parcel/packager-react-static": "^2.16.3"
"@parcel/packager-react-static": "^2.16.3",
"@sinclair/typebox": "0.27.10"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without this, typescript fails in node_modules/@jest/schemas/node_modules/@sinclair/typebox/typebox.d.ts which is very annoying because it cannot easily be patched

And the error isn't actually an error, it's Excessive stack depth comparing types

it's json schema types, so not very worried about it

@rspbot
Copy link

rspbot commented Feb 5, 2026

@snowystinger snowystinger changed the title feat: Update aria hide outside to work with shadow doms feat: Update aria hideoutside to work with shadow doms Feb 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ariaHideOutside incorrect behavior inside shadow DOM.

2 participants