Shadow DOM support for ariaHideOutside#6160
Closed
MahmoudElsayad wants to merge 14 commits intoadobe:mainfrom
Closed
Shadow DOM support for ariaHideOutside#6160MahmoudElsayad wants to merge 14 commits intoadobe:mainfrom
ariaHideOutside#6160MahmoudElsayad wants to merge 14 commits intoadobe:mainfrom
Conversation
…rt' into ariaHideOutside-shadow-dom-support
devongovett
force-pushed
the
main
branch
2 times, most recently
from
8cb1a5d to
3013156
Compare
devongovett
force-pushed
the
main
branch
2 times, most recently
from
a79adcf to
3013156
Compare
# Conflicts: # packages/@react-aria/overlays/test/ariaHideOutside.test.js
… the same shadow root as a parent.
ritz078
reviewed
Feb 7, 2025
| const shadowRoots = findShadowRoots(targets); | ||
|
|
||
| if (shadowRoots.length > 0) { | ||
| const targetsByShadowRoot = new Map<ShadowRoot, Element[]>(); |
Contributor
There was a problem hiding this comment.
The function ariaHideOutside already accepts a root element. Can we make this generic so that any element can be treated as root and not just the document.body or shadow root ? If an element passed as root is inside shadow root, even that should work. Does this make sense ?
This means that all the hooks using this function should also accept a custom root and should pass this information to this element.
5 tasks
5 tasks
Member
|
Thanks for your patience, I know this has been slow, but thank you so very much for the unit tests. They were really helpful to me when I was verifying my changes here feat: Update aria hide outside to work with shadow doms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6133
Changes
✅ Pull Request Checklist:
📝 Test Instructions:
🧢 Your Project:
PSPDFKit -