Skip to content

fix: correct ADCP_VERSION packaging for PyPI #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bokelley merged 2 commits into from
Nov 24, 2025
Merged

fix: correct ADCP_VERSION packaging for PyPI #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caf3bcf
fix: package ADCP_VERSION file correctly for PyPI distribution
bokelley Nov 24, 2025
891bd7f
refactor: use importlib.resources for ADCP_VERSION file access
bokelley Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,7 @@ Issues = "https://github.com/adcontextprotocol/adcp-client-python/issues"
where = ["src"]

[tool.setuptools.package-data]
adcp = ["py.typed"]

# Include ADCP_VERSION file in package
[tool.setuptools]
include-package-data = true

[tool.setuptools.data-files]
"." = ["ADCP_VERSION"]
adcp = ["py.typed", "ADCP_VERSION"]

[tool.black]
line-length = 100
Expand Down
0 ADCP_VERSION → src/adcp/ADCP_VERSION
View file
Open in desktop
File renamed without changes.
15 changes: 8 additions & 7 deletions src/adcp/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,15 +191,16 @@ def get_adcp_version() -> str:
of the AdCP specification.

Returns:
AdCP specification version (e.g., "v1", "v2")
AdCP specification version (e.g., "2.5.0")

Raises:
FileNotFoundError: If ADCP_VERSION file is missing from package
"""
from pathlib import Path
from importlib.resources import files

# Read from ADCP_VERSION file at project root
version_file = Path(__file__).parent.parent.parent / "ADCP_VERSION"
if version_file.exists():
return version_file.read_text().strip()
return "v1" # Fallback
# Read from ADCP_VERSION file in package
version_file = files("adcp") / "ADCP_VERSION"
return version_file.read_text().strip()

__all__ = [
# Version functions
Expand Down