fix: correct ADCP_VERSION packaging for PyPI #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, get_adcp_version() returned "v1" (fallback) when installed from PyPI because ADCP_VERSION was packaged in the wrong location (adcp-2.12.0.data/data/) and couldn't be found at runtime. Changes: - Move ADCP_VERSION into src/adcp/ package directory - Update pyproject.toml to include it as package data - Update get_adcp_version() to read from package location - Remove "v1" fallback to fail fast if file is missing Now returns "2.5.0" correctly when installed from PyPI. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Switch from Path(__file__) to importlib.resources.files() for more robust package data access across different installation methods (editable installs, zip imports, etc.). This is the modern, recommended way to access package data files in Python 3.9+. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed
get_adcp_version()returning "v1" fallback instead of "2.5.0" when installed from PyPI. The file was packaged in the wrong location, making it inaccessible at runtime.Changes
Test plan
🤖 Generated with Claude Code