feat: sync AdCP schema updates and simplify type architecture #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Sync 140 schemas from upstream (61 updated) including filter ref splits - Regenerate all Pydantic types with new schema structure - Add backward compatibility aliases for renamed types (e.g., Action → CreativeAction) - Export filter types (CreativeFilters, ProductFilters, SignalFilters) - Consolidate stable.py into types/__init__.py (eliminate redundant layer) - Update all imports from adcp.types.stable → adcp.types 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
bokelley
changed the title
Schema updated with latest changes from adcontextprotocol.org 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
- Fix import ordering in adcp/__init__.py - Remove duplicate ReportingFrequency import - Add GeneratedTaskStatus to __all__ exports - Organize imports according to ruff standards 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
The core TaskStatus enum was shadowing GeneratedTaskStatus, causing mypy to see the wrong type when client.py tried to access GeneratedTaskStatus enum members. Changes: - Remove TaskStatus from adcp.types exports to avoid shadowing - Import GeneratedTaskStatus directly instead of aliasing - Update imports in client.py and __init__.py - Fix import ordering per ruff standards This resolves mypy errors about TaskStatus not having .completed, .submitted, etc. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code