I18N: Add translator context to all 'Preview' strings#11700
Open
wppoland wants to merge 16 commits intoWordPress:trunkfrom
Open
I18N: Add translator context to all 'Preview' strings#11700wppoland wants to merge 16 commits intoWordPress:trunkfrom
wppoland wants to merge 16 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
`Preview` is a single English token that lands in translations as a verb (button labels), a noun (preview panes, table headers), or an iframe title. Without a translator context, all 14 in-tree occurrences collapsed onto one entry in `default.po`, forcing translators to choose a single rendering that fit poorly somewhere. This commit gives each occurrence a context that names both the part of speech and the surface it appears on, covering: * Post row action and post-lock dialog button (`verb, ...`). * Submit meta box preview button (`verb, action button to preview the post`). * Theme install list-table action and theme-install template buttons (`verb, ...`). * Theme preview iframe title (`noun, ...`). * Customizer toggle and takeover dialog (`verb`/`noun`, ...). * Header image and background image preview rows (`noun, ...`). * Classic-editor (TinyMCE) toolbar button (`verb, ...`). Extends the scope of WordPressGH-11407 and WordPressGH-11408, which only covered four of these spots. See #64986.
Member
|
Thanks for the PR! There might be some confusion here, we don't really need a separate context for each of these strings, that would be redundant and increase the workload for translators. As noted on the ticket already, just |
aaronjorbin
requested changes
May 7, 2026
Co-authored-by: Aaron Jorbin <aaronjorbin@users.noreply.github.com>
Co-authored-by: Aaron Jorbin <aaronjorbin@users.noreply.github.com>
Co-authored-by: Aaron Jorbin <aaronjorbin@users.noreply.github.com>
Co-authored-by: Aaron Jorbin <aaronjorbin@users.noreply.github.com>
Co-authored-by: Aaron Jorbin <aaronjorbin@users.noreply.github.com>
Co-authored-by: Aaron Jorbin <aaronjorbin@users.noreply.github.com>
Co-authored-by: Aaron Jorbin <aaronjorbin@users.noreply.github.com>
Co-authored-by: Aaron Jorbin <aaronjorbin@users.noreply.github.com>
Co-authored-by: Aaron Jorbin <aaronjorbin@users.noreply.github.com>
Co-authored-by: Aaron Jorbin <aaronjorbin@users.noreply.github.com>
Co-authored-by: Aaron Jorbin <aaronjorbin@users.noreply.github.com>
Co-authored-by: Aaron Jorbin <aaronjorbin@users.noreply.github.com>
Co-authored-by: Aaron Jorbin <aaronjorbin@users.noreply.github.com>
t-hamano
approved these changes
May 8, 2026
Contributor
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
I have applied all of @aaronjorbin's suggestions. The changes look good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/64986
Previewis a single English token that lands in translations as a verb (button labels), a noun (preview panes, table headers), or an iframe title. Without translator context, all 14 in-tree occurrences collapsed onto one entry indefault.po, forcing translators to choose a single rendering that fit poorly somewhere.This PR gives each occurrence a context that names both the part of speech and the surface it appears on:
verb, ...)verb, action button to preview the post)verb, ...)noun, ...)verb/noun, ...)noun, ...)verb, ...)Extends the scope of GH-11407 and GH-11408, which only covered four of these spots and used less specific context strings.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.