Skip to content

[18734] Add canonical redirect for categories with children #10854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kasparsd wants to merge 3 commits into
base: trunk
Choose a base branch
from
+99 −0
Open

[18734] Add canonical redirect for categories with children #10854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d266d8c
Add canonical redirect for categories with children
kasparsd Feb 3, 2026
73c6ae6
Use the helper to resolve this data
kasparsd Feb 3, 2026
f5beb2f
Use the request input for comparison since it matches the request path
kasparsd Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/wp-includes/canonical.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,28 @@ function redirect_canonical( $requested_url = null, $do_redirect = true ) {
$tax_url = get_term_link( (int) $obj->term_id, $obj->taxonomy );

if ( $tax_url && ! is_wp_error( $tax_url ) ) {
$category_permastruct = $wp_rewrite->get_category_permastruct();

// Ensure the correct parent-child category path is used in permalink.
if ( is_category()
&& ! empty( $obj->parent )
&& $category_permastruct
&& str_contains( $category_permastruct, '%category%' )
&& ! empty( $wp_query->query['category_name'] )
) {
$category_path_slug = get_category_parents( $obj->term_id, false, '/', true );

if ( $category_path_slug && ! is_wp_error( $category_path_slug ) ) {
$category_path_slug = untrailingslashit( $category_path_slug );
$category_path = str_replace( '%category%', $category_path_slug, $category_permastruct );
$request_category_path = str_replace( '%category%', $wp_query->query['category_name'], $category_permastruct );

if ( $category_path !== $request_category_path ) {
$redirect['path'] = str_replace( $request_category_path, $category_path, $redirect['path'] );
}
}
}

if ( ! empty( $redirect['query'] ) ) {
// Strip taxonomy query vars off the URL.
$qv_remove = array( 'term', 'taxonomy' );
Expand Down
27 changes: 27 additions & 0 deletions tests/phpunit/includes/testcase-canonical.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,33 @@ public static function generate_shared_fixtures( WP_UnitTest_Factory $factory )
)
);

// Insert a few posts in each category to enable pagination.
for ( $p = 0; $p < 6; $p++ ) {
self::$post_ids[] = $factory->post->create(
array(
'post_title' => 'Post in category parent ' . $p,
'post_type' => 'post',
'post_category' => array( self::$terms['/category/parent/'] ),
)
);

self::$post_ids[] = $factory->post->create(
array(
'post_title' => 'Post in category child-1 ' . $p,
'post_type' => 'post',
'post_category' => array( self::$terms['/category/parent/child-1/'] ),
)
);

self::$post_ids[] = $factory->post->create(
array(
'post_title' => 'Post in category child-2 ' . $p,
'post_type' => 'post',
'post_category' => array( self::$terms['/category/parent/child-1/child-2/'] ),
)
);
}

self::$term_ids[ $tag1 ] = 'post_tag';
}

Expand Down
50 changes: 50 additions & 0 deletions tests/phpunit/tests/canonical.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,56 @@ public function data_canonical() {
17174,
),

// Child categories with missing parent category slugs in the URL.
array(
'/category/child-1/',
array(
'url' => '/category/parent/child-1/',
'qv' => array( 'category_name' => 'parent/child-1' ),
),
),
array(
'/category/child-2/',
array(
'url' => '/category/parent/child-1/child-2/',
'qv' => array( 'category_name' => 'parent/child-1/child-2' ),
),
),
array(
'/category/parent/child-2/',
array(
'url' => '/category/parent/child-1/child-2/',
'qv' => array( 'category_name' => 'parent/child-1/child-2' ),
),
),
array(
'/category/too/many/parents/child-1/',
array(
'url' => '/category/parent/child-1/',
'qv' => array( 'category_name' => 'parent/child-1' ),
),
),
array(
'/category/child-1/page/2/',
array(
'url' => '/category/parent/child-1/page/2/',
'qv' => array(
'category_name' => 'parent/child-1',
'paged' => 2,
),
),
),
array(
'/category/child-1/child-2/page/2/',
array(
'url' => '/category/parent/child-1/child-2/page/2/',
'qv' => array(
'category_name' => 'parent/child-1/child-2',
'paged' => 2,
),
),
),

// Categories & intersections with other vars.
array(
'/category/uncategorized/?tag=post-formats',
Expand Down
Loading