Skip to content

Conversation

@kasparsd
Copy link

@kasparsd kasparsd commented Feb 3, 2026

Trac ticket: https://core.trac.wordpress.org/ticket/18734


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props kasparsd.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates redirect_canonical() so that category URLs for child terms are normalized to use the correct parent/child path, including paginated archives, and adds fixtures and tests to cover these cases (Trac #18734).

Changes:

  • Extend Tests_Canonical::data_canonical() with cases for child categories where the URL is missing parent slugs, has extra parent segments, or includes pagination.
  • Add shared fixtures that create posts in the parent, child-1, and child-2 categories to ensure category archives have multiple pages.
  • Adjust redirect_canonical() to rewrite the category portion of the path based on the actual term hierarchy and the category permalink structure when handling category queries.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tests/phpunit/tests/canonical.php Adds canonical redirection test cases for child category URLs with missing/extra parent segments and for paged category archives.
tests/phpunit/includes/testcase-canonical.php Extends shared fixtures to create enough posts in the parent, child-1, and child-2 categories to support paged archive tests.
src/wp-includes/canonical.php Updates redirect_canonical() taxonomy handling to normalize the category path portion of the URL to the correct parent/child hierarchy when %category% is used in the category permastruct.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant