Skip to content

Widgets: Remove unused variables in widget toggle handler #10815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huzaifaalmesbah wants to merge 3 commits into
base: trunk
Choose a base branch
from
+4 −17
Open

Widgets: Remove unused variables in widget toggle handler #10815

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4f5d81
Widgets: Remove unused variables in widget toggle handler
huzaifaalmesbah Jan 29, 2026
2e338c2
Admin Widgets: Remove unused isRTL variable.
huzaifaalmesbah Jan 29, 2026
ef3f18e
Merge branch 'trunk' into fix/27307-cleanup
huzaifaalmesbah Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 4 additions & 17 deletions src/js/_enqueues/admin/widgets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* @output wp-admin/js/widgets.js
*/

/* global ajaxurl, isRtl, wpWidgets */
/* global ajaxurl, wpWidgets */

(function($) {
var $document = $( document );
Expand All @@ -27,8 +27,7 @@ window.wpWidgets = {
self = this,
chooser = $('.widgets-chooser'),
selectSidebar = chooser.find('.widgets-chooser-sidebars'),
sidebars = $('div.widgets-sortables'),
isRTL = !! ( 'undefined' !== typeof isRtl && isRtl );
sidebars = $('div.widgets-sortables');

// Handle the widgets containers in the right column.
$( '#widgets-right .sidebar-name' )
Expand Down Expand Up @@ -113,15 +112,13 @@ window.wpWidgets = {
});

$(document.body).on('click.widgets-toggle', function(e) {
var target = $(e.target), css = {},
widget, inside, targetWidth, widgetWidth, margin, saveButton, widgetId,
var target = $(e.target),
widget, inside, saveButton, widgetId,
toggleBtn = target.closest( '.widget' ).find( '.widget-top button.widget-action' );

if ( target.parents('.widget-top').length && ! target.parents('#available-widgets').length ) {
widget = target.closest('div.widget');
inside = widget.children('.widget-inside');
targetWidth = parseInt( widget.find('input.widget-width').val(), 10 );
widgetWidth = widget.parent().width();
widgetId = inside.find( '.widget-id' ).val();

// Save button is initially disabled, but is enabled when a field is changed.
Expand All @@ -137,16 +134,6 @@ window.wpWidgets = {
}

if ( inside.is(':hidden') ) {
if ( targetWidth > 250 && ( targetWidth + 30 > widgetWidth ) && widget.closest('div.widgets-sortables').length ) {
if ( widget.closest('div.widget-liquid-right').length ) {
margin = isRTL ? 'margin-right' : 'margin-left';
} else {
margin = isRTL ? 'margin-left' : 'margin-right';
}

css[ margin ] = widgetWidth - ( targetWidth + 30 ) + 'px';
widget.css( css );
}
/*
* Don't change the order of attributes changes and animation:
* it's important for screen readers, see ticket #31476.
Expand Down
Loading