Widgets: Remove unused variables in widget toggle handler#10815
Widgets: Remove unused variables in widget toggle handler#10815huzaifaalmesbah wants to merge 3 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
mukeshpanchal27
left a comment
There was a problem hiding this comment.
JS error that needs to fix:
src/js/_enqueues/admin/widgets.js
31 | isRTL = !! ( 'undefined' !== typeof isRtl && isRtl );
^ 'isRTL' is defined but never used.
|
@mukeshpanchal27 Thanks for catching this. |
Ticket https://core.trac.wordpress.org/ticket/27307
Description
This PR refreshes and cleans up
src/js/_enqueues/admin/widgets.jsby removing unused variables (css,targetWidth,widgetWidth,margin) from theclick.widgets-toggleevent handler.Related patch: https://core.trac.wordpress.org/attachment/ticket/27307/27307.diff
How to test
npm run buildto ensure JavaScript compiles without errors.