Fixes from Nordic #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 2, 2023
Closed
Closed
Closed
This should be controlled by syslog feature define. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
This was found as a build warning, a typo in using logical OR condition to compare channels. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
These help point out trivial issues. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
eloop is used by both hostap and QT-APP, as C doesn't have namespaces, prefix all QT APIs with qt_. This is needed for those embedded build systems that compile both hostap + QT. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
force-pushed
the
nordic_super_pr
branch
from
ad3d5e2 to
568a533
Compare
krish2718
added a commit
to krish2718/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Aug 2, 2023
This should be controlled by syslog feature define. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
added a commit
to krish2718/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Aug 2, 2023
Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
added a commit
to krish2718/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Aug 2, 2023
This was found as a build warning, a typo in using logical OR condition to compare channels. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
added a commit
to krish2718/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Aug 2, 2023
These help point out trivial issues. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
added a commit
to krish2718/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Aug 2, 2023
Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
added a commit
to krish2718/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Aug 2, 2023
Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
added a commit
to krish2718/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Aug 2, 2023
Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
added a commit
to krish2718/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Aug 2, 2023
Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
added a commit
to krish2718/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Aug 2, 2023
Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
added a commit
to krish2718/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Aug 2, 2023
Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
added a commit
to krish2718/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Aug 2, 2023
Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
added a commit
to krish2718/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Aug 2, 2023
Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
added a commit
to krish2718/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Aug 2, 2023
eloop is used by both hostap and QT-APP, as C doesn't have namespaces, prefix all QT APIs with qt_. This is needed for those embedded build systems that compile both hostap + QT. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
added a commit
to krish2718/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Aug 2, 2023
Protects P2P code in case the DUT doesn't support it yet. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718
added a commit
to krish2718/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Aug 2, 2023
Protects WNM code in case the DUT doesn't support it yet. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718
added a commit
to krish2718/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Aug 2, 2023
Protects HS2.0 code in case the DUT doesn't support it yet. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718
added a commit
to krish2718/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Aug 2, 2023
Protects AP code in case the DUT doesn't support it yet. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718
added a commit
to krish2718/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Aug 2, 2023
Protects WPS code in case the DUT doesn't support it yet. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
krish2718
added a commit
to krish2718/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Aug 2, 2023
Fix only for C files. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
krish2718
added a commit
to krish2718/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Aug 2, 2023
These functions are only applicable for the test platform, so, include them only for it to avoid build errors. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Open
cvinayak
pushed a commit
to cvinayak/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Oct 19, 2023
This should be controlled by syslog feature define. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> (cherry picked from commit 0555304)
cvinayak
pushed a commit
to cvinayak/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Oct 19, 2023
Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> (cherry picked from commit 8b4f003)
cvinayak
pushed a commit
to cvinayak/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Oct 19, 2023
This was found as a build warning, a typo in using logical OR condition to compare channels. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> (cherry picked from commit c75f8d1)
cvinayak
pushed a commit
to cvinayak/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Oct 19, 2023
These help point out trivial issues. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> (cherry picked from commit 88c4dce)
cvinayak
pushed a commit
to cvinayak/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Oct 19, 2023
Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> (cherry picked from commit e53b2c9)
cvinayak
pushed a commit
to cvinayak/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Oct 19, 2023
Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> (cherry picked from commit 1229870)
cvinayak
pushed a commit
to cvinayak/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Oct 19, 2023
Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> (cherry picked from commit 2594c19)
cvinayak
pushed a commit
to cvinayak/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Oct 19, 2023
Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> (cherry picked from commit f4e326f)
cvinayak
pushed a commit
to cvinayak/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Oct 19, 2023
Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> (cherry picked from commit 44cdd05)
cvinayak
pushed a commit
to cvinayak/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Oct 19, 2023
Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> (cherry picked from commit 8af0123)
cvinayak
pushed a commit
to cvinayak/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Oct 19, 2023
Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> (cherry picked from commit 28136de)
cvinayak
pushed a commit
to cvinayak/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Oct 19, 2023
Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> (cherry picked from commit 55a82db)
cvinayak
pushed a commit
to cvinayak/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Oct 19, 2023
eloop is used by both hostap and QT-APP, as C doesn't have namespaces, prefix all QT APIs with qt_. This is needed for those embedded build systems that compile both hostap + QT. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> (cherry picked from commit 13ecf8b)
cvinayak
pushed a commit
to cvinayak/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Oct 19, 2023
Protects P2P code in case the DUT doesn't support it yet. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no> (cherry picked from commit 4f8cf56)
cvinayak
pushed a commit
to cvinayak/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Oct 19, 2023
Protects WNM code in case the DUT doesn't support it yet. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no> (cherry picked from commit f397c7a)
cvinayak
pushed a commit
to cvinayak/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Oct 19, 2023
Protects HS2.0 code in case the DUT doesn't support it yet. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no> (cherry picked from commit 32bc648)
cvinayak
pushed a commit
to cvinayak/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Oct 19, 2023
Protects AP code in case the DUT doesn't support it yet. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no> (cherry picked from commit 538efcc)
cvinayak
pushed a commit
to cvinayak/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Oct 19, 2023
Protects WPS code in case the DUT doesn't support it yet. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no> (cherry picked from commit ed5aeaa)
cvinayak
pushed a commit
to cvinayak/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Oct 19, 2023
Fix only for C files. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> (cherry picked from commit 17fe788)
cvinayak
pushed a commit
to cvinayak/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Oct 19, 2023
These functions are only applicable for the test platform, so, include them only for it to avoid build errors. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no> (cherry picked from commit d2f2481)
D-Triveni
pushed a commit
to D-Triveni/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Jan 5, 2024
These functions are only applicable for the test platform, so, include them only for it to avoid build errors. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
D-Triveni
pushed a commit
to nrfconnect/sdk-wi-fiquicktrack-controlappc
that referenced
this pull request
Jan 12, 2024
These functions are only applicable for the test platform, so, include them only for it to avoid build errors. Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#5 Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains all fixes from Nordic, instead of having multiple PRs with dependencies, this is easier to manage.