Build fixes #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

krish2718 wants to merge 13 commits into Wi-FiQuickTrack:main from krish2718:build_fixes

krish2718 commented May 29, 2023

No description provided.


          Fix build issues without syslog

b73efac

This should be controlled by syslog feature define.

krish2718 force-pushed the build_fixes branch from 54dd952 to 0c24bd7 Compare

May 29, 2023 20:07

krish2718 pushed a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Fix build issues without syslog

8d9c8de

This should be controlled by syslog feature define.

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 pushed a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Fix uninitialized build warnings

a0c0d3b

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 pushed a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Fix bug in channel comparison

64d47a8

This was found as a build warning, a typo in using logical OR condition
to compare channels.

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 pushed a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Enable minimal warnings

1ba217c

These help point out trivial issues.

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 pushed a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Fix signedness warning

0d0440c

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 pushed a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Fix unused variables warning

69d6aa5

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 pushed a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Fix unused function warning

cf2c33d

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 pushed a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Fix return value for function

45f2e55

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 pushed a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Fix build warning for print arg

422c22d

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 pushed a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Fix pedantic build warning

178b7eb

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 pushed a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Fix overlapping memory build warning

31ffb5d

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 pushed a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Fix set but ununsed build warning

7b55263

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 mentioned this pull request

Fix eloop namespace #3

Closed

krish2718 pushed a commit to nrfconnect/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Fix build issues without syslog

e02c091

This should be controlled by syslog feature define.

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 pushed a commit to nrfconnect/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Fix uninitialized build warnings

3be6e9b

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 pushed a commit to nrfconnect/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Fix bug in channel comparison

ceefa1f

This was found as a build warning, a typo in using logical OR condition
to compare channels.

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 pushed a commit to nrfconnect/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Enable minimal warnings

666ffa4

These help point out trivial issues.

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 pushed a commit to nrfconnect/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Fix signedness warning

a4d54bc

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 pushed a commit to nrfconnect/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Fix unused variables warning

afaf874

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 pushed a commit to nrfconnect/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Fix unused function warning

8c99f1f

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 pushed a commit to nrfconnect/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Fix return value for function

c9400c7

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 pushed a commit to nrfconnect/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Fix build warning for print arg

1a21977

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 pushed a commit to nrfconnect/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Fix pedantic build warning

0ffaccb

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 pushed a commit to nrfconnect/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Fix overlapping memory build warning

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 pushed a commit to nrfconnect/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist]: Fix set but ununsed build warning

dbd2a4f

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

krish2718 added a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist] Fix uninitialized warning

b445113

Upstream-PR: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>

krish2718 added a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist] Fix uninitialized warning

42fc2e6

Upstream-PR: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>

krish2718 added a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist] Fix uninitialized warning

53c38d8

Upstream-PR: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>

Krishna T and others added 4 commits

June 1, 2023 16:57


          Fix pedantic build warning

3e7bd28


          Fix overlapping memory build warning

8ae438e


          Fix set but ununsed build warning

72491e4


          Fix newlines

a713776

Remove starting newline and add ending newline.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>

krish2718 force-pushed the build_fixes branch from 0c24bd7 to a713776 Compare

June 1, 2023 11:27

krish2718 added a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist] Fix uninitialized warning

1b9203b

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>

krish2718 added a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist] Fix newlines

fc2fa8c

Remove starting newline and add ending newline.

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>

krish2718 added a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist] qt: Fix uninitialized warning

4febc2d

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>

krish2718 added a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist] qt: Fix newlines

1a6132d

Remove starting newline and add ending newline.

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>

krish2718 added a commit to nrfconnect/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist] qt: Fix uninitialized warning

67ce5a3

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>

krish2718 added a commit to nrfconnect/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist] qt: Fix newlines

a7d346d

Remove starting newline and add ending newline.

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>

Author

krish2718 commented Aug 2, 2023

Does this repo accept PRs?

D-Triveni pushed a commit to D-Triveni/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist] qt: Fix uninitialized warning

ed18f37

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>

D-Triveni pushed a commit to D-Triveni/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist] qt: Fix newlines

9fd4c41

Remove starting newline and add ending newline.

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>

Author

krish2718 commented Aug 2, 2023

In favour of #5

krish2718 closed this

krish2718 deleted the build_fixes branch

August 2, 2023 13:44

krish2718 added a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist] qt: Fix uninitialized warning

777628c

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>

krish2718 added a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist] qt: Fix newlines

73e82b5

Remove starting newline and add ending newline.

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>

krish2718 added a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist] qt: Fix uninitialized warning

4fa03a9

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>

krish2718 added a commit to krish2718/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist] qt: Fix newlines

0ae7eda

Remove starting newline and add ending newline.

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>

cvinayak pushed a commit to cvinayak/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist] qt: Fix uninitialized warning

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
(cherry picked from commit 4fa03a9)

cvinayak pushed a commit to cvinayak/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist] qt: Fix newlines

d644ab6

Remove starting newline and add ending newline.

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
(cherry picked from commit 0ae7eda)

D-Triveni pushed a commit to D-Triveni/sdk-nrf that referenced this pull request


          qt: Fix uninitialized warning

84ea556

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>

D-Triveni pushed a commit to D-Triveni/sdk-nrf that referenced this pull request


          qt: Fix uninitialized warning

c66f764

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>

D-Triveni pushed a commit to D-Triveni/sdk-nrf that referenced this pull request


          [nrf fromlist] qt: Fix uninitialized warning

5a5e893

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>

D-Triveni pushed a commit to D-Triveni/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist] qt: Fix newlines

d6e865c

Remove starting newline and add ending newline.

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>

D-Triveni pushed a commit to nrfconnect/sdk-wi-fiquicktrack-controlappc that referenced this pull request


          [nrf fromlist] qt: Fix newlines

656da3d

Remove starting newline and add ending newline.

Upstream-Pr: Wi-FiQuickTrack/Wi-FiQuickTrack-ControlAppC#2

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet