Skip to content

Update Wrench to 2.3.1 #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
windxu88 merged 4 commits into from
Mar 19, 2026
Merged

Update Wrench to 2.3.1 #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
485ce3f
Update Wrench to 2.3.1 and Editor versions in legacy CI
windxu88 Mar 13, 2026
0ea6631
Correct casing of one image file
windxu88 Mar 13, 2026
0cf1f58
Update doc generation brick to 0.5.3
windxu88 Mar 13, 2026
e12fa69
Use 2022.3 for test_api_win job
windxu88 Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .yamato/generated-scripts/infrastructure-instability-detection-linux.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ if [ -d "infrastructure_instability_detection_standalone" ]; then
rm -rf "infrastructure_instability_detection_standalone" || true
fi

echo "downloading and extracting infrastructure_instability_detection_standalone@1.0.0"
curl -fs "https://artifactory-slo.bf.unity3d.com/artifactory/automation-and-tooling/infrastructure-instability-detection/standalone/1.0.0/ubuntu.zip" --output "infrastructure_instability_detection_standalone.zip" --retry 5 || true
echo "downloading and extracting infrastructure_instability_detection_standalone@1.2.2"
curl -fs "https://artifactory-slo.bf.unity3d.com/artifactory/automation-and-tooling/infrastructure-instability-detection/standalone/1.2.2/ubuntu.zip" --output "infrastructure_instability_detection_standalone.zip" --retry 5 || true
Copy link

@u-pr u-pr bot Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium
The curl command is followed by || true, which means the script will proceed even if the tool fails to download after 5 retries. This could lead to infrastructure instability detection being silently skipped, potentially masking CI issues. Additionally, this behavior is inconsistent with the Windows script (.yamato/generated-scripts/infrastructure-instability-detection-win.cmd) which does not use the || true suffix for the same step.

🤖 Helpful? 👍/👎


if [ -d "infrastructure_instability_detection" ]; then
echo "removing infrastructure_instability_detection folder to avoid name clash"
Expand Down
4 changes: 2 additions & 2 deletions .yamato/generated-scripts/infrastructure-instability-detection-mac.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ if [ -d "infrastructure_instability_detection_standalone" ]; then
rm -rf "infrastructure_instability_detection_standalone" || true
fi

echo "downloading and extracting infrastructure_instability_detection_standalone@1.0.0"
curl -fs "https://artifactory-slo.bf.unity3d.com/artifactory/automation-and-tooling/infrastructure-instability-detection/standalone/1.0.0/macos.zip" --output "infrastructure_instability_detection_standalone.zip" --retry 5 || true
echo "downloading and extracting infrastructure_instability_detection_standalone@1.2.2"
curl -fs "https://artifactory-slo.bf.unity3d.com/artifactory/automation-and-tooling/infrastructure-instability-detection/standalone/1.2.2/macos.zip" --output "infrastructure_instability_detection_standalone.zip" --retry 5 || true

if [ -d "infrastructure_instability_detection" ]; then
echo "removing infrastructure_instability_detection folder to avoid name clash"
Expand Down
2 changes: 1 addition & 1 deletion .yamato/generated-scripts/infrastructure-instability-detection-win.cmd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
rem This is an auto-generated script. Do not edit manually!

if exist "%TEMP%\BugReporterCrashReportJson" for /f "delims=" %%i in ('dir /b /a-d "%TEMP%\BugReporterCrashReportJson\*.json"') do curl -X POST -H "Content-Type: application/json" -T "%TEMP%\BugReporterCrashReportJson\%%i" "https://internal-crash-collector.prd.cds.internal.unity3d.com/api/crash" || echo Failed to upload %%i. Ignoring...
curl -fs "https://artifactory-slo.bf.unity3d.com/artifactory/automation-and-tooling/infrastructure-instability-detection/standalone/1.0.0/windows.zip" --output "infrastructure_instability_detection_standalone.zip" --retry 5
curl -fs "https://artifactory-slo.bf.unity3d.com/artifactory/automation-and-tooling/infrastructure-instability-detection/standalone/1.2.2/windows.zip" --output "infrastructure_instability_detection_standalone.zip" --retry 5
IF EXIST "infrastructure_instability_detection" rmdir /s /q infrastructure_instability_detection
powershell.exe -nologo -noprofile -command "& { Add-Type -A 'System.IO.Compression.FileSystem'; [IO.Compression.ZipFile]::ExtractToDirectory('infrastructure_instability_detection_standalone.zip', '.'); }" && DEL "infrastructure_instability_detection_standalone.zip"
curl -fs "https://artifactory-slo.bf.unity3d.com/artifactory/automation-and-tooling/infrastructure-instability-detection/patterns.zip" --output patterns.zip --retry 5
Expand Down
9 changes: 5 additions & 4 deletions .yamato/global.metafile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,18 @@

all_test_editors:
- version: 2020.3
- version: 2021.3
- version: 2022.3
- version: 6000.0
- version: 6000.2
- version: 6000.3
- version: 6000.4
- version: 6000.5
- version: trunk

clean_console_test_editors:
- version: 2022.3
- version: 6000.0
- version: 6000.2
- version: 6000.3
- version: 6000.4
- version: 6000.5
- version: trunk

promotion_test_editors:
Expand Down
4 changes: 2 additions & 2 deletions .yamato/upm-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ generate_documentation:
# Run build script to copy CHANGELOG.md and LICENSE.md into com.unity.formats.fbx package.
- brew install cmake
- ./build.sh
- brick_source: git@github.cds.internal.unity3d.com:wind-xu/virtual_production_doc_generation.git@v0.3.0
- brick_source: git@github.cds.internal.unity3d.com:wind-xu/virtual_production_doc_generation.git@v0.5.3
variables:
EDITOR_VERSION: {{ all_test_editors.last.version }}
PACKAGE_NAME: com.unity.formats.fbx
Expand Down Expand Up @@ -123,7 +123,7 @@ test_api_win:
- gsudo choco source add -n Unity -s https://artifactory.prd.it.unity3d.com/artifactory/api/nuget/unity-choco-local
- gsudo choco install unity-config
- unity-config project set registry candidates --project-path TestProjects/fbx-api-tests
- unity-downloader-cli -u {{ all_test_editors[2].version }} -c Editor
- unity-downloader-cli -u 2022.3 -c Editor
- UnifiedTestRunner --suite=editor --editor-location=.Editor --testproject=TestProjects/fbx-api-tests --artifacts_path=artifacts --reruncount=0
artifacts:
logs:
Expand Down
20 changes: 12 additions & 8 deletions .yamato/wrench/api-validation-jobs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,17 @@
all_api_validation_jobs:
name: All API Validation Jobs
dependencies:
- path: .yamato/wrench/api-validation-jobs.yml#api_validation_-_formats_fbx_-_2020_3_-_windows
- path: .yamato/wrench/api-validation-jobs.yml#api_validation_-_formats_fbx_-_2020_3_-_win10

# upm-ci validation tests for API Validation - formats.fbx - 2020.3 - windows (2020.3 - Windows).
api_validation_-_formats_fbx_-_2020_3_-_windows:
name: API Validation - formats.fbx - 2020.3 - windows
# upm-ci validation tests for API Validation - formats.fbx - 2020.3 - win10 (2020.3 - Windows).
api_validation_-_formats_fbx_-_2020_3_-_win10:
name: API Validation - formats.fbx - 2020.3 - win10
agent:
image: package-ci/win10:default
image: package-ci/win10:v4
type: Unity::VM
flavor: b1.large
commands:
- command: curl https://artifactory.prd.it.unity3d.com/artifactory/stevedore-unity-internal/wrench-localapv/1-2-68_53c92d3b34ce3f4b652c9785dd1530bdc5885f6523465d6969c3be91f9ccaaf1.zip -o wrench-localapv.zip
- command: curl https://artifactory.prd.it.unity3d.com/artifactory/stevedore-unity-internal/wrench-localapv/1-3-0_3978eda62a03e3dbc469ab77590d20f8832032d8e0b586550597b7f590baefec.zip -o wrench-localapv.zip
- command: 7z x -aoa wrench-localapv.zip
- command: pip install semver requests --index-url https://artifactory-slo.bf.unity3d.com/artifactory/api/pypi/pypi/simple
- command: python PythonScripts/print_machine_info.py
Expand Down Expand Up @@ -51,8 +51,12 @@ api_validation_-_formats_fbx_-_2020_3_-_windows:
dependencies:
- path: .yamato/wrench/package-pack-jobs.yml#package_pack_-_formats_fbx
variables:
UPMPVP_CONTEXT_WRENCH: 1.1.1.0
UNITY_LICENSING_SERVER_BASE_URL: http://unity-ci-licenses.hq.unity3d.com:8080/
UNITY_LICENSING_SERVER_DELETE_NUL: 0
UNITY_LICENSING_SERVER_DELETE_ULF: 0
UNITY_LICENSING_SERVER_TOOLSET: pro
UPMPVP_CONTEXT_WRENCH: 2.3.1.0
metadata:
Job Maintainers: '#rm-packageworks'
Wrench: 1.1.1.0
Wrench: 2.3.1.0

4 changes: 2 additions & 2 deletions .yamato/wrench/package-pack-jobs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
package_pack_-_formats_fbx:
name: Package Pack - formats.fbx
agent:
image: package-ci/ubuntu-20.04:default
image: package-ci/ubuntu-22.04:v4
type: Unity::VM
flavor: b1.large
commands:
Expand All @@ -26,5 +26,5 @@ package_pack_-_formats_fbx:
UPMCI_ACK_LARGE_PACKAGE: 1
metadata:
Job Maintainers: '#rm-packageworks'
Wrench: 1.1.1.0
Wrench: 2.3.1.0

4 changes: 4 additions & 0 deletions .yamato/wrench/player-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Auto-generated by Recipe Engine, do not modify manually.
# This job is generated by the wrench recipe engine module, see find the docs here: http://Go/ii2fb
{}

4 changes: 4 additions & 0 deletions .yamato/wrench/player-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Auto-generated by Recipe Engine, do not modify manually.
# This job is generated by the wrench recipe engine module, see find the docs here: http://Go/ii2fb
{}

Loading