Conversation
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
There was a problem hiding this comment.
The code review found two medium-importance issues related to CI infrastructure stability and coverage reporting configuration. Please address the potential for silent failures in the Linux shell script and verify the simplified coverage settings.
🤖 Helpful? 👍/👎
| echo "downloading and extracting infrastructure_instability_detection_standalone@1.0.0" | ||
| curl -fs "https://artifactory-slo.bf.unity3d.com/artifactory/automation-and-tooling/infrastructure-instability-detection/standalone/1.0.0/ubuntu.zip" --output "infrastructure_instability_detection_standalone.zip" --retry 5 || true | ||
| echo "downloading and extracting infrastructure_instability_detection_standalone@1.2.2" | ||
| curl -fs "https://artifactory-slo.bf.unity3d.com/artifactory/automation-and-tooling/infrastructure-instability-detection/standalone/1.2.2/ubuntu.zip" --output "infrastructure_instability_detection_standalone.zip" --retry 5 || true |
There was a problem hiding this comment.
The curl command is followed by || true, which means the script will proceed even if the tool fails to download after 5 retries. This could lead to infrastructure instability detection being silently skipped, potentially masking CI issues. Additionally, this behavior is inconsistent with the Windows script (.yamato/generated-scripts/infrastructure-instability-detection-win.cmd) which does not use the || true suffix for the same step.
🤖 Helpful? 👍/👎
2 participants
Purpose of this PR
Update Wrench to
2.3.1and changecom.unity.formats.fbx/Documentation~/images/FBXExporter_MayaExportSetAttributes.PNGto lower case extFBXExporter_MayaExportSetAttributes.png..PNGcan fail PVP check:Ticket/Jira #:
Testing
Functional Testing status:
Performance Testing status:
Documentation & UX Writing
Additional information
Note to reviewers:
Reminder: