Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,28 +61,28 @@ A headless table library for building powerful datagrids with full control over
<table align="center">
<tr>
<td>
<a href="https://www.coderabbit.ai/?via=tanstack&dub_id=aCcEEdAOqqutX6OS">
<picture>
<source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/coderabbit-dark-CMcuvjEy.svg" height="40" />
<source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/coderabbit-light-DVMJ2jHi.svg" height="40" />
<img src="https://tanstack.com/assets/coderabbit-light-DVMJ2jHi.svg" height="40" alt="CodeRabbit" />
</picture>
</a>
<a href="https://www.coderabbit.ai/?via=tanstack&dub_id=aCcEEdAOqqutX6OS" >
<picture>
<source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/coderabbit-dark-D643Zkrv.svg" height="40" />
<source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/coderabbit-light-CIzGLYU_.svg" height="40" />
<img src="https://tanstack.com/assets/coderabbit-light-CIzGLYU_.svg" height="40" alt="CodeRabbit" />
</picture>
</a>
</td>
<td padding="20">
<a href="https://www.cloudflare.com?utm_source=tanstack">
<picture>
<source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/cloudflare-white-DQDB7UaL.svg" height="60" />
<source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/cloudflare-black-CPufaW0B.svg" height="60" />
<img src="https://tanstack.com/assets/cloudflare-black-CPufaW0B.svg" height="60" alt="Cloudflare" />
</picture>
<picture>
<source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/cloudflare-white-Co-Tyjbl.svg" />
<source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/cloudflare-black-6Ojsn8yh.svg" />
<img src="https://tanstack.com/assets/cloudflare-white-Co-Tyjbl.svg" height="60" alt="Cloudflare" />
</picture>
</a>
</td>
<td>
<a href="https://ag-grid.com/react-data-grid/?utm_source=reacttable&utm_campaign=githubreacttable" style="display: flex; align-items: center; border: none;">
<picture>
<source media="(prefers-color-scheme: dark)" srcset="./media/ag-grid-dark.svg" height="40" />
<source media="(prefers-color-scheme: light)" srcset="./media/ag-grid-light.svg" height="40" />
<source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/ag-grid-dark.svg" height="40" />
<source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/ag-grid-light.svg" height="40" />
<img src="https://raw.githubusercontent.com/tannerlinsley/files/master/partners/ag-grid.svg" height="60" alt="AG Grid" />
Comment on lines +84 to 86
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Verify picture/img host consistency for AG Grid block in README.md
rg -n -A4 -B2 'ag-grid-(dark|light)\.svg|partners/ag-grid\.svg' README.md

Repository: TanStack/table

Length of output: 686


Align AG Grid fallback image with the new asset sources.

The <source> tags reference TanStack-hosted assets (tanstack.com/assets/ag-grid-*.svg), but the fallback <img> still points to a legacy GitHub URL. Fallback-only environments will display a different logo.

Suggested fix
-        <img src="https://raw.githubusercontent.com/tannerlinsley/files/master/partners/ag-grid.svg" height="60" alt="AG Grid" />
+        <img src="https://tanstack.com/assets/ag-grid-light.svg" height="60" alt="AG Grid" />
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/ag-grid-dark.svg" height="40" />
<source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/ag-grid-light.svg" height="40" />
<img src="https://raw.githubusercontent.com/tannerlinsley/files/master/partners/ag-grid.svg" height="60" alt="AG Grid" />
<source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/ag-grid-dark.svg" height="40" />
<source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/ag-grid-light.svg" height="40" />
<img src="https://tanstack.com/assets/ag-grid-light.svg" height="60" alt="AG Grid" />
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@README.md` around lines 84 - 86, The fallback <img> currently points to the
legacy GitHub URL while the <source> tags use TanStack-hosted assets; update the
<img> tag's src to the matching TanStack asset (same base as the srcset URLs,
e.g., tanstack.com/assets/ag-grid-*.svg) so environments that use the fallback
display the same logo as the <source> variants and keep the height/alt
attributes (refer to the existing <source> tags and the <img> element to locate
the change).

</picture>
</a>
Expand Down