Conversation
|
📝 WalkthroughWalkthroughUpdated README sponsor markup: replaced several sponsor image URLs (dark/light variants), corrected an img attribute, and adjusted HTML spacing/indentation. No code or behavior changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Line 68: Fix the malformed img tag by adding the missing opening quote for the
src attribute so the element becomes valid HTML; update the img element (the
<img ... /> shown in the diff) to use
src="https://tanstack.com/assets/coderabbit-light-CIzGLYU_.svg" and verify the
rest of the attributes (height and alt) remain unchanged.
- Around line 64-78: The CodeRabbit light logo img tag is malformed: update the
<img> element that currently reads
src=https://tanstack.com/assets/coderabbit-light-CIzGLYU_.svg" to include the
missing opening quote so it becomes
src="https://tanstack.com/assets/coderabbit-light-CIzGLYU_.svg"; verify the
other <img> tags (Cloudflare and dark/light sources) use consistent quoted
src/srcset attributes and correct any similar quoting mistakes (look for the
CodeRabbit <img> element inside the <picture> block).
|
I am not able to find ag-grid logo its an svg |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@README.md`:
- Around line 84-86: The fallback <img> currently points to the legacy GitHub
URL while the <source> tags use TanStack-hosted assets; update the <img> tag's
src to the matching TanStack asset (same base as the srcset URLs, e.g.,
tanstack.com/assets/ag-grid-*.svg) so environments that use the fallback display
the same logo as the <source> variants and keep the height/alt attributes (refer
to the existing <source> tags and the <img> element to locate the change).
| <source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/ag-grid-dark.svg" height="40" /> | ||
| <source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/ag-grid-light.svg" height="40" /> | ||
| <img src="https://raw.githubusercontent.com/tannerlinsley/files/master/partners/ag-grid.svg" height="60" alt="AG Grid" /> |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify picture/img host consistency for AG Grid block in README.md
rg -n -A4 -B2 'ag-grid-(dark|light)\.svg|partners/ag-grid\.svg' README.mdRepository: TanStack/table
Length of output: 686
Align AG Grid fallback image with the new asset sources.
The <source> tags reference TanStack-hosted assets (tanstack.com/assets/ag-grid-*.svg), but the fallback <img> still points to a legacy GitHub URL. Fallback-only environments will display a different logo.
Suggested fix
- <img src="https://raw.githubusercontent.com/tannerlinsley/files/master/partners/ag-grid.svg" height="60" alt="AG Grid" />
+ <img src="https://tanstack.com/assets/ag-grid-light.svg" height="60" alt="AG Grid" />📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| <source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/ag-grid-dark.svg" height="40" /> | |
| <source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/ag-grid-light.svg" height="40" /> | |
| <img src="https://raw.githubusercontent.com/tannerlinsley/files/master/partners/ag-grid.svg" height="60" alt="AG Grid" /> | |
| <source media="(prefers-color-scheme: dark)" srcset="https://tanstack.com/assets/ag-grid-dark.svg" height="40" /> | |
| <source media="(prefers-color-scheme: light)" srcset="https://tanstack.com/assets/ag-grid-light.svg" height="40" /> | |
| <img src="https://tanstack.com/assets/ag-grid-light.svg" height="60" alt="AG Grid" /> |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@README.md` around lines 84 - 86, The fallback <img> currently points to the
legacy GitHub URL while the <source> tags use TanStack-hosted assets; update the
<img> tag's src to the matching TanStack asset (same base as the srcset URLs,
e.g., tanstack.com/assets/ag-grid-*.svg) so environments that use the fallback
display the same logo as the <source> variants and keep the height/alt
attributes (refer to the existing <source> tags and the <img> element to locate
the change).
1 participant
🎯 Changes
✅ Checklist
pnpm test:pr.Summary by CodeRabbit