Skip to content

[Refactor] Remove duplication in git latest tag retrieval #7546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
gonzaloriestra wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −2
Draft

[Refactor] Remove duplication in git latest tag retrieval #7546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/cli-kit/src/public/node/git.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,8 +233,7 @@ export async function downloadGitRepository(cloneOptions: GitCloneOptions): Prom
}

async function getLatestTagFromDirectory(directory: string, repoUrl: string): Promise<string> {
const stdout = await gitCommand(['describe', '--tags', '--abbrev=0'], directory)
const tag = stdout.trim()
const tag = await getLatestTag(directory)

if (!tag) {
throw new AbortError(`Couldn't obtain the most recent tag of the repository ${repoUrl}`)
Expand Down
Loading