[Refactor] Remove duplication in git latest tag retrieval#7546
[Refactor] Remove duplication in git latest tag retrieval#7546gonzaloriestra wants to merge 1 commit into
Conversation
Refactors getLatestTagFromDirectory in packages/cli-kit/src/public/node/git.ts to use the existing getLatestTag utility, removing duplicated git command execution.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The logic for executing
git describe --tags --abbrev=0and trimming the output was duplicated ingetLatestTagFromDirectoryandgetLatestTagwithinpackages/cli-kit/src/public/node/git.ts. Centralizing this logic improves maintainability.WHAT is this pull request doing?
Refactors
getLatestTagFromDirectoryto call the existinggetLatestTaghelper function, removing the duplicated command execution.How to test your changes?
You can verify the git tag retrieval logic continues to work by running the unit tests for the git module:
Duplicate check
I performed a manual check using
git logsince theghtool was unavailable.Closest prior PRs considered:
311ee45f7 [Refactor] Extract shared execution environment logic in system.ts: Refactorssystem.tsto extract environment logic; different subsystem.088a35a45 [Refactor] Consolidate command execution in system.ts: Consolidates logic insystem.ts; different subsystem.8fbf32490 [Refactor] Fix incorrect Promise.all usage in app preDeployValidation: Fixes an async anti-pattern inapp.ts; different technique and subsystem.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 12497117072717296991 started by @gonzaloriestra