Skip to content

[Refactor] Remove duplication in git latest tag retrieval#7546

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
jules-refactor-git-tag-duplication-12497117072717296991
Draft

[Refactor] Remove duplication in git latest tag retrieval#7546
gonzaloriestra wants to merge 1 commit into
mainfrom
jules-refactor-git-tag-duplication-12497117072717296991

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The logic for executing git describe --tags --abbrev=0 and trimming the output was duplicated in getLatestTagFromDirectory and getLatestTag within packages/cli-kit/src/public/node/git.ts. Centralizing this logic improves maintainability.

WHAT is this pull request doing?

Refactors getLatestTagFromDirectory to call the existing getLatestTag helper function, removing the duplicated command execution.

How to test your changes?

You can verify the git tag retrieval logic continues to work by running the unit tests for the git module:

pnpm --filter @shopify/cli-kit vitest run src/public/node/git.test.ts

Duplicate check

I performed a manual check using git log since the gh tool was unavailable.
Closest prior PRs considered:

  • 311ee45f7 [Refactor] Extract shared execution environment logic in system.ts: Refactors system.ts to extract environment logic; different subsystem.
  • 088a35a45 [Refactor] Consolidate command execution in system.ts: Consolidates logic in system.ts; different subsystem.
  • 8fbf32490 [Refactor] Fix incorrect Promise.all usage in app preDeployValidation: Fixes an async anti-pattern in app.ts; different technique and subsystem.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 12497117072717296991 started by @gonzaloriestra

Refactors getLatestTagFromDirectory in packages/cli-kit/src/public/node/git.ts to use the existing getLatestTag utility, removing duplicated git command execution.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label May 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant