Remove Clone impls on ciphers/RNGs
#462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow cloning on a stream cipher or RNG is problematic because it duplicates internal states, which can lead to keystream reuse / RNG output duplication, which in cryptographic contexts can be catastrophic. Instead, for things like tests ciphers can be initialized from the same seed repeatedly, which is what this PR changes the e.g. `chacha20` tests to do. This is a much more explicit way of deliberately duplicating stream ciphers/RNGs for the purposes of testing. See also: - #220 - #461 - RustCrypto/block-modes/pull/91 - rust-random/rand#1101
tarcieri
force-pushed
the
remove-clone-impls
branch
from
4af656c to
764ed69
Compare
newpavlov
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow cloning on a stream cipher or RNG is problematic because it duplicates internal states, which can lead to keystream reuse / RNG output duplication, which in cryptographic contexts can be catastrophic.
Instead, for things like tests ciphers can be initialized from the same seed repeatedly, which is what this PR changes the e.g.
chacha20tests to do. This is a much more explicit way of deliberately duplicating stream ciphers/RNGs for the purposes of testing.See also:
Cloneimpls on RNGs #220serdefeature #461Cloneimpls block-modes#91