Skip to content

Missing Clone implementation for Rc4Core #488

@TheBestTvarynka

Description

@TheBestTvarynka

Hi,

For a long time, I used the custom Rc4 algorithm implementation, but decided to replace it with the rc4. I want to be consistent with the existing Rust crypto traits.

Suddenly, I've discovered that the Rc4Core does not implement the Clone trait. It is needed to satisfy the following condition: https://docs.rs/rc4/latest/rc4/type.Rc4.html#impl-Clone-for-StreamCipherCoreWrapper%3CT%3E.

I browsed other implementations of encryption algorithms (like aes or des), and they all implement the Clone trait. But Rc4Code, ChaChaCore, and Hc256Core do not implement Clone. Is it intentional? If not, I would like to have the Clone trait implementation (it is needed for my project), and I am willing to submit a PR.

Thank you in advance 🙏

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions