Skip to content

BUG: Fix missing titles in roll parameter plots for fin sets #934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gui-FernandesBR merged 3 commits into from
Mar 8, 2026
+3 −1
Merged

BUG: Fix missing titles in roll parameter plots for fin sets #934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dbad259
BUG: Fix missing titles in roll parameter plots for fin sets
Gui-FernandesBR Mar 8, 2026
a0ecef2
MNT: Update CHANGELOG for PR #934
Gui-FernandesBR Mar 8, 2026
4edaa75
Merge branch 'develop' into claude/condescending-albattani
Gui-FernandesBR Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ Attention: The newest changes should be on top -->
- BUG: energy_data plot not working for 3 dof sims [[#906](https://github.com/RocketPy-Team/RocketPy/issues/906)]
- BUG: Fix CSV column header spacing in FlightDataExporter [#864](https://github.com/RocketPy-Team/RocketPy/issues/864)
- BUG: Fix parallel Monte Carlo simulation showing incorrect iteration count [#806](https://github.com/RocketPy-Team/RocketPy/pull/806)
- BUG: Fix missing titles in roll parameter plots for fin sets [#934](https://github.com/RocketPy-Team/RocketPy/pull/934)
- BUG: Duplicate _controllers in Flight.TimeNodes.merge() [#931](https://github.com/RocketPy-Team/RocketPy/pull/931)

## [v1.11.0] - 2025-11-01
Expand Down
1 change: 0 additions & 1 deletion rocketpy/plots/aero_surface_plots.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,6 @@ def roll(self):
None
"""
print("Roll parameters:")
# TODO: lacks a title in the plots
self.aero_surface.roll_parameters[0]()
self.aero_surface.roll_parameters[1]()

Expand Down
2 changes: 2 additions & 0 deletions rocketpy/rocket/aero_surface/fins/fins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,7 @@ def evaluate_roll_parameters(self):
) # Function of mach number
clf_delta.set_inputs("Mach")
clf_delta.set_outputs("Roll moment forcing coefficient derivative")
clf_delta.set_title(None)
cld_omega = (
2
* self.roll_damping_interference_factor
Expand All @@ -339,6 +340,7 @@ def evaluate_roll_parameters(self):
) # Function of mach number
cld_omega.set_inputs("Mach")
cld_omega.set_outputs("Roll moment damping coefficient derivative")
cld_omega.set_title(None)
self.roll_parameters = [clf_delta, cld_omega, self.cant_angle_rad]
return self.roll_parameters

Expand Down