Skip to content

BUG: Fix missing titles in roll parameter plots for fin sets#934

Merged
Gui-FernandesBR merged 3 commits intodevelopfrom
claude/condescending-albattani
Mar 8, 2026
Merged

BUG: Fix missing titles in roll parameter plots for fin sets#934
Gui-FernandesBR merged 3 commits intodevelopfrom
claude/condescending-albattani

Conversation

@Gui-FernandesBR
Copy link
Member

Call set_title(None) on clf_delta and cld_omega after set_inputs/set_outputs in Fins.evaluate_roll_parameters() so the title is auto-generated from the updated axis names instead of remaining None.

Pull request type

  • Code maintenance (refactoring, formatting, tests)

Checklist

  • Tests for the changes have been added (if needed)
  • Docs have been reviewed and added / updated
  • Lint (black rocketpy/ tests/) has passed locally
  • All tests (pytest tests -m slow --runslow) have passed locally
  • CHANGELOG.md has been updated (if relevant)

Breaking change

  • No

Additional information

I'm testing claude code for the very first time

Call set_title(None) on clf_delta and cld_omega after set_inputs/set_outputs
in Fins.evaluate_roll_parameters() so the title is auto-generated from the
updated axis names instead of remaining None.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@Gui-FernandesBR Gui-FernandesBR requested a review from a team as a code owner March 8, 2026 22:31
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@codecov
Copy link

codecov bot commented Mar 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.04%. Comparing base (9cf3dd4) to head (4edaa75).
⚠️ Report is 32 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #934      +/-   ##
===========================================
+ Coverage    80.27%   81.04%   +0.76%     
===========================================
  Files          104      107       +3     
  Lines        12769    13888    +1119     
===========================================
+ Hits         10250    11255    +1005     
- Misses        2519     2633     +114     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a plotting metadata regression in RocketPy fin-set roll parameter plots by ensuring Function.title is regenerated after updating axis labels.

Changes:

  • Regenerate titles for clf_delta and cld_omega in Fins.evaluate_roll_parameters() by calling set_title(None) after set_inputs/set_outputs.
  • Remove an outdated TODO comment in fin roll plotting helper.
  • Add a changelog entry documenting the bug fix.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
rocketpy/rocket/aero_surface/fins/fins.py Resets roll-parameter Function.title to auto-generate from updated input/output axis names.
rocketpy/plots/aero_surface_plots.py Removes TODO comment now addressed by the fix.
CHANGELOG.md Records the bug fix in the Unreleased “Fixed” section.

@Gui-FernandesBR Gui-FernandesBR merged commit b0bc810 into develop Mar 8, 2026
14 checks passed
@Gui-FernandesBR Gui-FernandesBR deleted the claude/condescending-albattani branch March 8, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants