Skip to content

as.data.table.array: copy shared dimnames before reversing them #7509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ben-schwen merged 2 commits into from
Dec 23, 2025
+13 −1
Merged

as.data.table.array: copy shared dimnames before reversing them #7509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10fcb66
regression test
aitap Dec 23, 2025
036b8e1
copy shared values before overwriting
aitap Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion R/as.data.table.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,8 +102,9 @@ as.data.table.array = function(x, keep.rownames=FALSE, key=NULL, sorted=TRUE, va
lapply(dx, seq_len)
} else if (any(nulldnx <- vapply_1b(dnx, is.null))) {
dnx[nulldnx] = lapply(dx[nulldnx], seq_len) #3636
setattr(dnx, 'names', copy(names(dnx)))
dnx
} else dnx
} else copy(dnx)
setfrev(val)
if (is.null(names(val)) || !any(nzchar(names(val))))
setattr(val, 'names', paste0("V", frev(seq_along(val))))
Expand Down
11 changes: 11 additions & 0 deletions inst/tests/tests.Rraw
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21921,3 +21921,14 @@ rm(DTn, DTl, DT)
DT = unserialize(serialize(as.data.table(mtcars), NULL))
test(2353, DT[,foo:=mean(mpg),by=cyl], as.data.table(mtcars)[,foo:=mean(mpg),by=cyl])
rm(DT)

# as.data.table.array(x) shouldn't overwrite dimnames(x), #7506
Xdn = list(foo = letters[1:2], bar = LETTERS[1:3], baz = as.character(1:4))
X = array(1:24, 2:4, copy(Xdn))
DT = as.data.table(X)
test(2354.1, dimnames(X), Xdn)
Xdn['baz'] = list(NULL)
dimnames(X) = copy(Xdn)
DT = as.data.table(X)
test(2354.2, dimnames(X), Xdn)
rm(X, Xdn, DT)
Loading