Skip to content

Conversation

@aitap
Copy link
Member

@aitap aitap commented Dec 23, 2025

Fixes: #7506. Tested by installing HEAD of this PR and re-running R CMD check ctsem_*.tar.gz. It still fails tests on my machine, but due to unrelated problems in parallelly cluster startup, not in data.table. Previously, setfrev() could be called on either dimnames(x) or a list that shared names(dimnames(x)), mutating x as a result.

@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.04%. Comparing base (ba7a1b3) to head (036b8e1).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7509   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files          87       87           
  Lines       16704    16705    +1     
=======================================
+ Hits        16544    16545    +1     
  Misses        160      160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@MichaelChirico MichaelChirico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was there not a place to just change setfrev() to frev() to get the copy?

@ben-schwen ben-schwen merged commit e455714 into master Dec 23, 2025
12 checks passed
@ben-schwen ben-schwen deleted the as.data.table-less-frev branch December 23, 2025 15:59
@github-actions
Copy link

  • HEAD=as.data.table-less-frev stopped early for isoweek improved in #7144
  • HEAD=as.data.table-less-frev slower P<0.001 for memrecycle regression fixed in #5463
    Comparison Plot

Generated via commit 036b8e1

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 5 minutes and 17 seconds
Installing different package versions 11 minutes and 47 seconds
Running and plotting the test cases 5 minutes and 8 seconds

@aitap
Copy link
Member Author

aitap commented Dec 25, 2025

Given that it took me three tries to get both tests to pass, maybe replacing setfrev with frev was a better idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

revdep ctsem failure in rbindlist

3 participants