Improve Diagonal constructors with similar_diagonal
#330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
kshyatt
reviewed
Dec 16, 2025
src/factorizations/diagonal.jl
Outdated
| V_dom = fuse(domain(t)) | ||
| U = similar(t, codomain(t) ← V_cod) | ||
| S = DiagonalTensorMap{real(scalartype(t))}(undef, V_cod ← V_dom) | ||
| S = similar_diagonal(t, real(scalartype(t)), V_cod ← V_dom) |
kshyatt
previously approved these changes
Dec 16, 2025
Member
kshyatt
left a comment
kshyatt
left a comment
There was a problem hiding this comment.
OK, I think this will really simplify things for the GPU support. Thanks very much for doing this!
Jutho
reviewed
Dec 16, 2025
Jutho
reviewed
Dec 16, 2025
Jutho
reviewed
Dec 16, 2025
Jutho
reviewed
Dec 16, 2025
Co-authored-by: Jutho <Jutho@users.noreply.github.com>
Jutho
reviewed
Dec 16, 2025
Jutho
previously approved these changes
Dec 16, 2025
Co-authored-by: Jutho <Jutho@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the (unexported for now?)
similar_diagonalfunction which acts likesimilarbut instead returns aDiagonalTensorMap.The main point is to facilitate GPU support by correctly taking into account the storage types of the provided input tensor.