Skip to content

Dedup sam2 and sam3 models#563

Open
dsobek wants to merge 1 commit intov9.1from
deduplicate-sam-models
Open

Dedup sam2 and sam3 models#563
dsobek wants to merge 1 commit intov9.1from
deduplicate-sam-models

Conversation

@dsobek
Copy link
Copy Markdown

@dsobek dsobek commented Apr 3, 2026

src/ went from 5.9G to 4.2G.

To validate this PR, you can run all the changed objectives (I've already done this).

Closes https://github.com/PickNikRobotics/moveit_pro/issues/17828

@dsobek dsobek added this to the 9.1.1 milestone Apr 3, 2026
@dsobek dsobek self-assigned this Apr 3, 2026
@dsobek dsobek requested a review from rlpratt12 April 3, 2026 22:22
Copy link
Copy Markdown
Member

@nbbrooks nbbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retarget to ...main?

Also should we be concerned about some of the re-rdering and utf v UTF? Is your linter settings out of sync with what is aimed at main or did we change something in that recently?

@dsobek
Copy link
Copy Markdown
Author

dsobek commented Apr 3, 2026

Retarget to ...main?

Also should we be concerned about some of the re-rdering and utf v UTF? Is your linter settings out of sync with what is aimed at main or did we change something in that recently?

I figured this can catch 9.1.1 and this'll get merged back to main after release.

For the linter settings, which diff are you referring to?

@dsobek dsobek requested a review from nbbrooks April 3, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants