Skip to content

Fix offhand unequip during node power process with Giant's Blood #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 1 commit into from
Feb 17, 2026
+10 −7
Merged

Fix offhand unequip during node power process with Giant's Blood #1766

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/Modules/CalcSetup.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,14 +781,17 @@ function calcs.initEnv(build, mode, override, specEnv)
instrumentsOfPower = nodesModsList:Flag(nil, "InstrumentsOfPower") or false,
lordOfTheWilds = nodesModsList:Flag(nil, "LordOfTheWilds") or false,
}
local cache = build.itemsTab.lastWeaponFlagState
local losingGiantsBlood = cache and cache.giantsBlood and not weaponFlagState.giantsBlood
local losingInstrumentsOfPower = cache and cache.instrumentsOfPower and not weaponFlagState.instrumentsOfPower
local losingLordOfTheWilds = cache and cache.lordOfTheWilds and not weaponFlagState.lordOfTheWilds
if losingGiantsBlood or losingInstrumentsOfPower or losingLordOfTheWilds then -- Only validate socket when losing Keystone / Ascendancy
build.itemsTab:ValidateWeaponSlots(weaponFlagState)
-- Only mutate equipped items in the real build pass; calculator overrides (e.g. node power) are transient.
if mode == "MAIN" then
local cache = build.itemsTab.lastWeaponFlagState
local losingGiantsBlood = cache and cache.giantsBlood and not weaponFlagState.giantsBlood
local losingInstrumentsOfPower = cache and cache.instrumentsOfPower and not weaponFlagState.instrumentsOfPower
local losingLordOfTheWilds = cache and cache.lordOfTheWilds and not weaponFlagState.lordOfTheWilds
if losingGiantsBlood or losingInstrumentsOfPower or losingLordOfTheWilds then -- Only validate socket when losing Keystone / Ascendancy
build.itemsTab:ValidateWeaponSlots(weaponFlagState)
end
build.itemsTab.lastWeaponFlagState = { giantsBlood = weaponFlagState.giantsBlood, instrumentsOfPower = weaponFlagState.instrumentsOfPower, lordOfTheWilds = weaponFlagState.lordOfTheWilds }
end
build.itemsTab.lastWeaponFlagState = { giantsBlood = weaponFlagState.giantsBlood, instrumentsOfPower = weaponFlagState.instrumentsOfPower, lordOfTheWilds = weaponFlagState.lordOfTheWilds }

-- Build and merge item modifiers, and create list of radius jewels
if not accelerate.requirementsItems then
Expand Down