Skip to content

Conversation

@MariusStorhaug
Copy link
Member

@MariusStorhaug MariusStorhaug commented Jan 28, 2026

Summary

Remove the Process-PSModule.yml workflow file pattern and examples/ directory from the important files list that determines whether a PR should trigger a release.

Changes

Modified

  • src/main.ps1:
    • Removed .github/workflows/Process-PSModule.yml from the $importantPatterns array
    • Removed examples/ from the $importantPatterns array
    • Updated the documentation table in PR comments accordingly

Reason for Change

  • Workflow file: Changes to the workflow file are maintenance/infrastructure changes, not functional changes to the module itself
  • Examples: Examples are not currently included in documentation generation, so changes to them should not trigger releases

Impact

PRs that only modify the workflow file or example scripts will no longer trigger build, test, and publish stages unless other important files (src/ or README.md) are also modified.

Release Note

  • Workflow file and example script changes no longer trigger module releases

@MariusStorhaug MariusStorhaug marked this pull request as ready for review January 28, 2026 14:51
Copilot AI review requested due to automatic review settings January 28, 2026 14:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modifies the important files detection logic in the GitHub Action that determines whether PR changes should trigger module releases. While the PR description indicates it removes only the workflow file pattern, the actual changes remove both .github/workflows/Process-PSModule.yml and examples/** from the important files list.

Changes:

  • Removed .github/workflows/Process-PSModule.yml pattern from $importantPatterns array
  • Removed examples/** pattern from $importantPatterns array
  • Updated the documentation table in the PR comment template to reflect the removed patterns

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MariusStorhaug MariusStorhaug self-assigned this Jan 28, 2026
@MariusStorhaug MariusStorhaug changed the title 🩹 [Patch]: Remove workflow file from important files pattern list 🩹 [Patch]: Remove unimportant files from the importantFiles pattern list Jan 28, 2026
@MariusStorhaug MariusStorhaug merged commit 3d53e12 into main Jan 28, 2026
15 checks passed
@MariusStorhaug MariusStorhaug deleted the fix/remove-workflow-from-important-files branch January 28, 2026 16:11
@MariusStorhaug MariusStorhaug restored the fix/remove-workflow-from-important-files branch January 28, 2026 16:16
@MariusStorhaug MariusStorhaug deleted the fix/remove-workflow-from-important-files branch January 28, 2026 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants