Add Podman compatibility to vox:build task#228
Merged
nmburgan merged 1 commit intoOpenVoxProject:mainfrom Apr 5, 2026
Merged
Conversation
Sharpie
force-pushed
the
vox-build-podman-compat
branch
from
a0f6561 to
9a9cc01
Compare
Prior to this commit, running the `vox:build` task via the
`podman-docker` shim would fail as `podman ls --format json` prints
an empty array, `[]`, when no containers match `--filter`. This differs
from `docker ls` behavior of printing nothing to STDOUT. This extra
output resulted in the `container_exists` function returning a false
positive, which caused the task to fail when trying to run `podman stop`
on containers that didn't exist.
This commit changes the command to use `--format '{{json .ID}}'` as
this produces the same behavior from both `podman` and `docker`:
no STDOUT when nothing matches, and a quoted string containing the
container ID when there is a match.
Signed-off-by: Charlie Sharpsteen <charlie@overlookinfratech.com>
Sharpie
force-pushed
the
vox-build-podman-compat
branch
from
9a9cc01 to
927989f
Compare
Contributor
Author
|
This PR has been tested by running |
Contributor
Author
|
Aha, this does have some overlap with #227 , that PR goes a bit further and removes the dependency on the |
nmburgan
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, running the
vox:buildtask via thepodman-dockershim would fail aspodman ls --format jsonprints an empty array,[], when no containers match--filter. This differs fromdocker lsbehavior of printing nothing to STDOUT. This extra output resulted in thecontainer_existsfunction returning a false positive, which caused the task to fail when trying to runpodman stopon containers that didn't exist.This commit changes the command to use
--format='{{json .ID}}'as this produces the same behavior from bothpodmananddocker: no STDOUT when nothing matches, and a quoted string containing the container ID when there is a match.