Support podman in tasks/build.rake#227
Open
gregorynisbet-google wants to merge 2 commits intoOpenVoxProject:mainfrom
Open
Support podman in tasks/build.rake#227gregorynisbet-google wants to merge 2 commits intoOpenVoxProject:mainfrom
gregorynisbet-google wants to merge 2 commits intoOpenVoxProject:mainfrom
Conversation
Support podman in addition to docker in tasks/build.rake via the DOCKER environment variable.
…of catching exceptions.
Contributor
|
I opened #228 before I noticed this PR. The approach there is even simpler, but requires the use of the Building other OpenVox components, such as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support podman in addition to docker in tasks/build.rake via the DOCKER environment variable.
Pull Request (PR) description
I did the simplest thing I could think of to make
DOCKER=podman rake vox:buildsucceed.There are a few differences between
--format jsonfor Docker and podman, but I still thinkthat that's the most robust way to get the commands to emit structured output.
I'm curious whether folks think this is worth doing at all, and whether an environment variable
is the best way of achieving this (and also whether shell substitution is better than doing the
conditional at the ruby level)
This Pull Request (PR) fixes the following issues
n/a