Skip to content

Raise max video resolution limit from 1920x1080 to 3840x2160 #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sunilnom wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

Raise max video resolution limit from 1920x1080 to 3840x2160 #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/util/config_reader.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,8 +417,8 @@ int validate_tx_config(const struct dvledtx_config* config) {
LOG_ERROR("video width/height must be non-zero");
return -1;
}
if (config->width > 1920 || config->height > 1080) {
LOG_ERROR("video resolution %dx%d exceeds maximum 1920x1080",
if (config->width > 3840 || config->height > 2160) {
LOG_ERROR("video resolution %dx%d exceeds maximum 3840x2160",
config->width, config->height);
Comment on lines +421 to 422
return -1;
}
Expand Down
2 changes: 1 addition & 1 deletion tests/test_config_reader.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,7 @@ static void test_validate_resolution_exceeds_max_fails(void **state)
(void)state;
struct dvledtx_config cfg;
fill_valid_config(&cfg);
cfg.width = 2000; /* > 1920 limit */
cfg.width = 4000; /* > 3840 limit */

@dmkarthi dmkarthi Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add unit tests to validate 2k and 4k resolutions, update README with the resolution support

assert_int_equal(validate_tx_config(&cfg), -1);
}

Expand Down
Loading