Raise max video resolution limit from 1920x1080 to 3840x2160#29
Open
sunilnom wants to merge 1 commit into
Open
Raise max video resolution limit from 1920x1080 to 3840x2160#29sunilnom wants to merge 1 commit into
sunilnom wants to merge 1 commit into
Conversation
- Update validation in config_reader to allow 2K and 4K resolutions - Update test to reflect new 3840x2160 maximum
There was a problem hiding this comment.
Pull request overview
This PR increases the maximum allowed video resolution in the JSON config validation from 1920×1080 to 3840×2160, and updates the corresponding unit test to reflect the new limit.
Changes:
- Updated
validate_tx_config()to allow resolutions up to 3840×2160. - Updated the unit test that verifies validation fails when the configured resolution exceeds the maximum.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_config_reader.c | Updates the “exceeds max resolution” validation test input to exceed the new 3840 width limit. |
| src/util/config_reader.c | Raises the max width/height validation thresholds and updates the associated error message. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+421
to
422
| LOG_ERROR("video resolution %dx%d exceeds maximum 3840x2160", | ||
| config->width, config->height); |
dmkarthi
reviewed
Jun 8, 2026
| struct dvledtx_config cfg; | ||
| fill_valid_config(&cfg); | ||
| cfg.width = 2000; /* > 1920 limit */ | ||
| cfg.width = 4000; /* > 3840 limit */ |
Collaborator
There was a problem hiding this comment.
add unit tests to validate 2k and 4k resolutions, update README with the resolution support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
Code Quality
Testing
Review Readiness
Documentation
Security
PR Type
What kind of change does this PR introduce?