Preserve HTTP parameter order #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogin
force-pushed
the
preserve-http-parameter-order
branch
from
a2e7a6b to
abfeb65
Compare
rogin
force-pushed
the
preserve-http-parameter-order
branch
from
abfeb65 to
ee8719d
Compare
kryskool
approved these changes
Aug 22, 2025
pacmano1
approved these changes
Aug 30, 2025
pacmano1
requested review from
Copilot,
gibson9583,
jonbartels,
kayyagari,
mgaffigan and
pacmano1
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where HTTP query parameters were not being sent in the order they were defined when using a map variable. The fix changes HttpUtil.getTableMap() to use LinkedHashMap instead of HashMap to preserve insertion order, which is important for APIs that expect parameters in a specific sequence.
Key Changes:
- Modified
HttpUtil.getTableMap()to return aLinkedHashMapinstead ofHashMapto preserve parameter order - Added a unit test
testMapOrderPreserved()to verify that map key order is maintained when retrieving table maps
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| server/src/com/mirth/connect/util/HttpUtil.java | Changed HashMap to LinkedHashMap in getTableMap method to preserve insertion order of HTTP parameters |
| server/test/com/mirth/connect/util/HttpUtilTest.java | Added test case to verify that key order is preserved when copying maps through getTableMap |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pacmano1
approved these changes
Dec 13, 2025
tonygermano
force-pushed
the
preserve-http-parameter-order
branch
from
ee8719d to
6ba242c
Compare
Contributor
|
This seems to be merged in BL already: Innovar-Healthcare/BridgeLink@bca952d |
mgaffigan
approved these changes
Dec 13, 2025
tonygermano
requested changes
Dec 13, 2025
Member
tonygermano
left a comment
tonygermano
left a comment
There was a problem hiding this comment.
This PR replaces the authorship from the original PR (the bridgelink commit does not acknowledge either of the two original authors.)
The HttpUtil.getTableMap method creates and returns a copy of a Map. This commit changes the new Map instance from a HashMap to a LinkedHashMap in order to preserve the iteration order of the original Map being copied. Issue: nextgenhealthcare/connect#6276 Original-pull-request: nextgenhealthcare/connect#6296 Signed-off-by: Tony Germano <tony@germano.name>
Signed-off-by: Richard Ogin <rogin@users.noreply.github.com>
tonygermano
force-pushed
the
preserve-http-parameter-order
branch
from
6ba242c to
1cf1c6f
Compare
tonygermano
approved these changes
Dec 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue where query parameters on an HTTP Sender Connector are not sent in order.
Apart from the included unit test, I have not verified this solution on my local machine.
Related
Original ticket - nextgenhealthcare/connect#6276
Previous PR - nextgenhealthcare/connect#6296
Summary table in #121