[IDEA] Review priority bugs from Mirth Connect

[rogin]

Similar to what Innovar performed which I liked, I pulled what I considered worthwhile from Mirth Connect's bug label, which also includes a few features and a security option worth investigating. These were copied to a local Excel file about a month ago, so a few more may be added should I recheck. Initial sizing and proposed value also provided.

Helpful Excel to Markdown converter here.

Excel file for convenience: OIE_task_migration.xlsx

OIE Issue or PR	General Issue	NextGen Issue #	NextGen Pull #	Type	T-Shirt Size	Proposed Value	Comment
	Mirth Connect 4.1.1.b303 creates corrupted keystore.jks when using "encryption.properties = 1"	5466	NONE	BUG		High
	DB Reader... (Generate).. Select Button..Get Tables... empty string does NOT retrieve all tables	4876	NONE	BUG		Medium
	Attachment Handler does not accomodate more than 40 characters for mime type	4479	NONE	BUG
	Client GlobalMap Dashboard Viewer does not correctly display multiple entries where the keys only differ by case	5314	NONE	BUG
	DefaultConfigurationController.initializeSecuritySettings writes the keystore unnecessarily	5467	NONE	BUG		High	Marked high value as it would preserve file's timestamp
#124 #125	Mirth Client Crashes when doing a Test Write on File Writer with no value in Directory field	4963	NONE	BUG		High
	Channel custom metadata variable mapping disallows some common characters	6332	NONE	BUG
	HTTP 404 error (Not Found) reported for unrecognized date input to API	6144	NONE	BUG		High	Part of larger effort to return proper status codes across all endpoints?
	DefaultUserController.removePreference is broken	5965	NONE	BUG
	dir.logs in preferences does not have any effect	5428	NONE	BUG
	PHI Events not working	5872	NONE	BUG
	/connectionLogs/{channelId} API doesn't respect fetch size	4748	NONE	BUG	SMALL	Low
#122 #123	usernames are case-sensitive	5569	NONE	BUG	SMALL	High
	ChannelController.updateChannel does not enforce certain rules	4633	NONE	BUG	MEDIUM	High
#133	destinationSet.removeAllExcept doesn't remove destinations if no match is found	5875	NONE	BUG	SMALL	High	Comment at the bottom on a potential quick fix
	Alert names can contain special characters that are invalid in filenames, causing the export to fail	5379	NONE	BUG	MEDIUM	Medium
	Data Pruner password protection encryption type can't be set properly	5270	NONE	BUG
	Tag Manager has bad channel count for tags assigned	5267	NONE	BUG		Medium
	Frame needs to load Extensions sooner	6046	NONE	BUG	MEDIUM	High	May need testing of paid and free extensions to ensure a quality solution
#129	Update Migrate4_5_2.java to allow for log4j2-cli.properties not being present	NONE	6327	BUG	SMALL		Existing PR = small size
	Commented 2 unnecessary indexes present in a few D_MC and D_MM tables.	4605	4565	FEATURE	SMALL	Low	Existing PR = small size
#130	Default 24 hour notation for search criteria	NONE	5989	FEATURE	SMALL	Medium	Existing PR = small size
#131	Query Parameters on an HTTP Sender Connector are not sent in order	6276	6296	FEATURE	SMALL	High	Existing PR = small size. Could also be BUG.
	Add HTTP Headers to Web Service Listener	6337	6339	FEATURE	SMALL		Existing PR = small size
	Channel Groups cannot save with Channel Filter on	3898	NONE	FEATURE	LARGE		Could also be BUG.
	Cannot set some SMTP Sender properties	5987	NONE	FEATURE
	HSTS not enabled	5897	NONE	SECURITY			OBE if WebAdmin is removed?

[tonygermano]

Thanks for pulling this together!

[sbraconnier]

I'm is-simon (this was my username at the place I worked at the time I opened some of these issues). I just wanted to note that there is a workaround for the Cannot set some SMTP Sender properties - 5987 issue.

If you add an header named CC with a comma separated list of emails as value, it works for the cc property.

Same thing for the bcc (BCC header) and replyTo (REPLY_TO header).

[rogin]

Concerning 6144 "HTTP 404 error (Not Found) reported for unrecognized date input to API"

Sample server response containing invalid date format:
{ "servlet": "org.glassfish.jersey.servlet.ServletContainer-6337a15e", "message": "Not Found", "url": "/api/channels/f8790fdf-8aab-4961-9855-0fed9a1a4469/messages", "status": "404" }

• The startDate format is clearly provided in the swagger API, so the user knowingly provided an invalid string.
• I agree that 404 is not the right response when the date format is incorrect and 400 is more appropriate.
• AI says Jersey's default behavior is to throw a 404 when a parse exception occurs, which matches the server output above. Several options may be available for this, but it's worth discussing a generalized solution to satisfy multiple endpoints.