Skip to content

fix: update Go tests for config and vault changes #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NormB merged 1 commit into from
Dec 8, 2025
Merged

fix: update Go tests for config and vault changes #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions reference-apps/golang/internal/config/config_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@ func TestLoad(t *testing.T) {
if cfg.Environment != "development" {
t.Errorf("Expected Environment development, got %s", cfg.Environment)
}
if cfg.Debug != true {
t.Errorf("Expected Debug true (default), got %v", cfg.Debug)
// Debug should default to false for security (opt-in, not opt-out)
if cfg.Debug != false {
t.Errorf("Expected Debug false (default for security), got %v", cfg.Debug)
}
},
},
Expand Down
80 changes: 43 additions & 37 deletions reference-apps/golang/internal/services/vault_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,46 +8,52 @@ import (

func TestNewVaultClient(t *testing.T) {
tests := []struct {
name string
addr string
token string
wantErr bool
name string
addr string
token string
appRoleDir string
wantErr bool
}{
{
name: "valid address and token",
addr: "http://vault:8200",
token: "test-token",
wantErr: false,
name: "valid address and token",
addr: "http://vault:8200",
token: "test-token",
appRoleDir: "",
wantErr: false,
},
{
name: "valid https address",
addr: "https://vault:8200",
token: "test-token",
wantErr: false,
name: "valid https address",
addr: "https://vault:8200",
token: "test-token",
appRoleDir: "",
wantErr: false,
},
{
name: "empty token (valid - token can be empty initially)",
addr: "http://vault:8200",
token: "",
wantErr: false,
name: "empty token (valid - token can be empty initially)",
addr: "http://vault:8200",
token: "",
appRoleDir: "",
wantErr: false,
},
{
name: "localhost address",
addr: "http://localhost:8200",
token: "test-token",
wantErr: false,
name: "localhost address",
addr: "http://localhost:8200",
token: "test-token",
appRoleDir: "",
wantErr: false,
},
{
name: "custom port",
addr: "http://vault:9200",
token: "test-token",
wantErr: false,
name: "custom port",
addr: "http://vault:9200",
token: "test-token",
appRoleDir: "",
wantErr: false,
},
}

for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
client, err := NewVaultClient(tt.addr, tt.token)
client, err := NewVaultClient(tt.addr, tt.token, tt.appRoleDir)

if tt.wantErr {
if err == nil {
Expand Down Expand Up @@ -78,7 +84,7 @@ func TestVaultClient_GetSecret(t *testing.T) {
// Full integration tests would require a running Vault instance

t.Run("context timeout handling", func(t *testing.T) {
client, err := NewVaultClient("http://nonexistent:8200", "test-token")
client, err := NewVaultClient("http://nonexistent:8200", "test-token", "")
if err != nil {
t.Fatalf("Failed to create client: %v", err)
}
Expand All @@ -94,7 +100,7 @@ func TestVaultClient_GetSecret(t *testing.T) {
})

t.Run("context cancellation", func(t *testing.T) {
client, err := NewVaultClient("http://nonexistent:8200", "test-token")
client, err := NewVaultClient("http://nonexistent:8200", "test-token", "")
if err != nil {
t.Fatalf("Failed to create client: %v", err)
}
Expand All @@ -109,7 +115,7 @@ func TestVaultClient_GetSecret(t *testing.T) {
})

t.Run("method accepts valid path", func(t *testing.T) {
client, err := NewVaultClient("http://vault:8200", "test-token")
client, err := NewVaultClient("http://vault:8200", "test-token", "")
if err != nil {
t.Fatalf("Failed to create client: %v", err)
}
Expand All @@ -132,7 +138,7 @@ func TestVaultClient_GetSecret(t *testing.T) {

func TestVaultClient_GetSecretKey(t *testing.T) {
t.Run("method signature validation", func(t *testing.T) {
client, err := NewVaultClient("http://vault:8200", "test-token")
client, err := NewVaultClient("http://vault:8200", "test-token", "")
if err != nil {
t.Fatalf("Failed to create client: %v", err)
}
Expand All @@ -153,7 +159,7 @@ func TestVaultClient_GetSecretKey(t *testing.T) {
})

t.Run("context handling", func(t *testing.T) {
client, err := NewVaultClient("http://nonexistent:8200", "test-token")
client, err := NewVaultClient("http://nonexistent:8200", "test-token", "")
if err != nil {
t.Fatalf("Failed to create client: %v", err)
}
Expand All @@ -170,7 +176,7 @@ func TestVaultClient_GetSecretKey(t *testing.T) {

func TestVaultClient_HealthCheck(t *testing.T) {
t.Run("health check method exists", func(t *testing.T) {
client, err := NewVaultClient("http://vault:8200", "test-token")
client, err := NewVaultClient("http://vault:8200", "test-token", "")
if err != nil {
t.Fatalf("Failed to create client: %v", err)
}
Expand All @@ -190,7 +196,7 @@ func TestVaultClient_HealthCheck(t *testing.T) {
})

t.Run("context cancellation handling", func(t *testing.T) {
client, err := NewVaultClient("http://nonexistent:8200", "test-token")
client, err := NewVaultClient("http://nonexistent:8200", "test-token", "")
if err != nil {
t.Fatalf("Failed to create client: %v", err)
}
Expand All @@ -210,7 +216,7 @@ func TestVaultClientStructure(t *testing.T) {
addr := "http://vault:8200"
token := "test-token"

client, err := NewVaultClient(addr, token)
client, err := NewVaultClient(addr, token, "")
if err != nil {
t.Fatalf("Failed to create client: %v", err)
}
Expand All @@ -225,7 +231,7 @@ func TestVaultClientStructure(t *testing.T) {
})

t.Run("client methods are accessible", func(t *testing.T) {
client, err := NewVaultClient("http://vault:8200", "test-token")
client, err := NewVaultClient("http://vault:8200", "test-token", "")
if err != nil {
t.Fatalf("Failed to create client: %v", err)
}
Expand All @@ -241,7 +247,7 @@ func TestVaultClientStructure(t *testing.T) {

func TestVaultClientConcurrency(t *testing.T) {
t.Run("client is safe for concurrent use", func(t *testing.T) {
client, err := NewVaultClient("http://vault:8200", "test-token")
client, err := NewVaultClient("http://vault:8200", "test-token", "")
if err != nil {
t.Fatalf("Failed to create client: %v", err)
}
Expand Down Expand Up @@ -269,7 +275,7 @@ func TestVaultClientConcurrency(t *testing.T) {

func TestVaultClientErrorFormatting(t *testing.T) {
t.Run("GetSecret error includes path", func(t *testing.T) {
client, err := NewVaultClient("http://nonexistent:8200", "test-token")
client, err := NewVaultClient("http://nonexistent:8200", "test-token", "")
if err != nil {
t.Fatalf("Failed to create client: %v", err)
}
Expand All @@ -292,7 +298,7 @@ func TestVaultClientErrorFormatting(t *testing.T) {
})

t.Run("GetSecretKey error includes key name", func(t *testing.T) {
client, err := NewVaultClient("http://nonexistent:8200", "test-token")
client, err := NewVaultClient("http://nonexistent:8200", "test-token", "")
if err != nil {
t.Fatalf("Failed to create client: %v", err)
}
Expand Down
Loading