fix: update Go tests for config and vault changes #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update config_test.go to expect Debug=false default (security fix) - Update vault_test.go to include appRoleDir parameter in NewVaultClient calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
config_test.goto expectDebug=falseas the default value (aligns with security fix from PR fix: codebase improvements from analysis #50)vault_test.goto include theappRoleDirparameter in allNewVaultClientcalls (matches updated function signature)Problem
After PR #50 merged, the Go tests were failing:
config_test.goexpectedDebug=truedefault, but it was changed tofalsefor securityvault_test.gowas callingNewVaultClient(addr, token)but the function now requires 3 parameters:NewVaultClient(addr, token, appRoleDir)Test plan
go test ./...in reference-apps/golang/ - all tests pass