[REVIEW #1871 FIRST] NeoUI - Full server queuing + automatic joining#1913
Draft
nullsystem wants to merge 2 commits intoNeotokyoRebuild:masterfrom
Draft
[REVIEW #1871 FIRST] NeoUI - Full server queuing + automatic joining#1913nullsystem wants to merge 2 commits intoNeotokyoRebuild:masterfrom
nullsystem wants to merge 2 commits intoNeotokyoRebuild:masterfrom
Conversation
NeoUI table headers and main table API implemented, now have
Begin/EndTable and NextTableRow implementation replacing the
previous custom paint + button. Now can just layout the table
cells with widgets, although at the moment only NeoUI::Label
are properly utilized and dealt with. Other widgets are not
refactored up for tables yet.
The table headers now have dragable resizing and the server
browser now have tags column. There's also right-click on
the header to show/hide columns.
Sections now have X-axis scrolling, mainly used for table and
header scrolling support.
Re-done NeoUI::Tabs scrolling, now it's held externally and
its own thing.
OTHERS:
* Fix SDR/Steam networking server bot vs player number count
* Fix border in smaller resolutions
* Added IP Address (hidden by default) column
FUTURE TODOs:
* Section X-scrollbar controls options/flags
* Modes:
* No X-scrollbar
* Indicator/thin X-scrollbar
* Dragable/thick X-scrollbar
* Using BeginTable will automatically put
the section into Dragable/thick X-scrollbar
mode
* Some TODOs in source code
* Change from only header to any sections to reference other
section's scrolls
* Refactor painting of widgets to utilize vgui viewports
* Possible split of painting (and colors) from NeoUI internals
* Vertical layouting that expands horizontally as oppose to the
default horizontal layouting that expands vertically
* fixes NeotokyoRebuild#1566
* fixes NeotokyoRebuild#994
* fixes NeotokyoRebuild#1815
nullsystem
changed the title
nullsystem
force-pushed
the
GH-1298_AutoJoin
branch
from
affd81c to
d162207
Compare
On entering a server, a ping-reply is now sent to the server to get the most up to date players count upon entering. Auto-join is determined if the server's full when trying to enter, and if so enters an auto-join state where it'll refresh for 15s checking count then entering when there's a free slot available. The auto-join popup bar stays on any states. * fixes NeotokyoRebuild#1298
nullsystem
force-pushed
the
GH-1298_AutoJoin
branch
from
d162207 to
dc3b58a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IN DRAFT: RELIES ON #1871 TO GO IN FIRST
Description
On entering a server, a ping-reply is now sent to the server to get the most up to date players count upon entering. Auto-join is determined if the server's full when trying to enter, and if so enters an auto-join state where it'll refresh for 15s checking count then entering when there's a free slot available. The auto-join popup bar stays on any states.
Toolchain
Linked Issues