Fix SRCDS failing to read client cvar defaults#1893
Open
Rainyan wants to merge 2 commits intoNeotokyoRebuild:masterfrom
Open
Fix SRCDS failing to read client cvar defaults#1893Rainyan wants to merge 2 commits intoNeotokyoRebuild:masterfrom
Rainyan wants to merge 2 commits intoNeotokyoRebuild:masterfrom
Conversation
Also add assertions to sanity check bounds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug where the SRCDS
CBasePlayerconstructor attempts to unsuccessfully read default values of client-only cvars. Instead, make constant variables for accessing those values.The bug was introduced in 07169a7 by yours truly, as part of #1657
Toolchain
Linked Issues