Add DCGM exporter pod metadata enrichment API#2406
Merged
karthikvetrivel merged 1 commit intoMay 12, 2026
Merged
Conversation
karthikvetrivel
requested review from
cdesiniotis,
rahulait,
rajathagasthya,
shivamerla and
tariq1890
as code owners
rahulait
reviewed
May 1, 2026
rahulait
reviewed
May 1, 2026
karthikvetrivel
force-pushed
the
fix/dcgm-exporter-pod-enrichment
branch
4 times, most recently
from
aa28ce9 to
ab5a207
Compare
tariq1890
reviewed
May 4, 2026
tariq1890
reviewed
May 4, 2026
karthikvetrivel
force-pushed
the
fix/dcgm-exporter-pod-enrichment
branch
from
ab5a207 to
39fb8d8
Compare
tariq1890
reviewed
May 4, 2026
| // +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors.x-descriptors="urn:alm:descriptor:com.tectonic.ui:advanced" | ||
| HPCJobMapping *DCGMExporterHPCJobMappingConfig `json:"hpcJobMapping,omitempty"` | ||
|
|
||
| // Enable Kubernetes pod labels in metrics. Requires cluster-level read access to pods. |
Contributor
There was a problem hiding this comment.
This feels a bit too terse. Can we expand on this a bit more? Let's also clarify that this setting adds pod label as a label dimension to the DCGM exporter prometheus metrics.
Also, the "Requires cluster-level read access to pods" is a bit unnecessary IMO. If we do want to mention this, can we enclose it in parenthesis?
Member
Author
There was a problem hiding this comment.
Yep, expanded on the label and enclosed "Requires cluster-level read access to pods" in parentheses.
karthikvetrivel
force-pushed
the
fix/dcgm-exporter-pod-enrichment
branch
from
39fb8d8 to
5e5530f
Compare
tariq1890
reviewed
May 11, 2026
tariq1890
reviewed
May 11, 2026
Signed-off-by: Karthik Vetrivel <kvetrivel@nvidia.com>
karthikvetrivel
force-pushed
the
fix/dcgm-exporter-pod-enrichment
branch
from
5e5530f to
146f17f
Compare
tariq1890
reviewed
May 12, 2026
tariq1890
approved these changes
May 12, 2026
5 tasks
rahulait
added a commit
that referenced
this pull request
May 21, 2026
This is required so that newer version of dcgm-exporter can have correct rbac permissions if needed Signed-off-by: Rahul Sharma <rahulsharm@nvidia.com>
Contributor
|
/cherry-pick release-26.3 |
Contributor
|
🤖 Backport PR created for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #2009.
Previously, there was no way of enabling pod metrics when using DCGM exporter through GPU Operator. This fix introduces introduces first-class Helm values that provision RBAC and allow pod metrics to include Pod UID & Pod Label.
Design Choices:
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
Added unit tests.
Confirmed the operator reconciled the expected DCGM exporter resources:
nvidia-dcgm-exporterDaemonSet rolled out successfully.-
DCGM_EXPORTER_KUBERNETES_ENABLE_POD_LABELS=true-
DCGM_EXPORTER_KUBERNETES_ENABLE_POD_UID=true-
DCGM_EXPORTER_KUBERNETES_POD_LABEL_ALLOWLIST_REGEX=^gpu_test_label$automountServiceAccountToken: true.nvidia-dcgm-exporter-read-podsClusterRole and ClusterRoleBinding were created.get,list, andwatchpods cluster-wide.Scraped DCGM exporter metrics from a labeled GPU pod and confirmed metrics included
gpu_test_label="live-test"andpod_uid="..."