backport rbac permissions for dcgm-exporter pod#2472
Closed
rahulait wants to merge 1 commit into
Closed
Conversation
This is required so that newer version of dcgm-exporter can have correct rbac permissions if needed Signed-off-by: Rahul Sharma <rahulsharm@nvidia.com>
714ac61 to
0fa652f
Compare
Contributor
|
Can we explore doing a complete backport instead? I'd prefer keeping branches easily comparable by cherrypicking exact commits |
Contributor
Author
|
We can close this in favor of #2475 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required so that newer version of dcgm-exporter can have correct rbac permissions if needed
Description
This PR does a partial backport of #2406
We added support to have rbac installed only when the appropriate flags are set. This PR brings in that change to 26.3 release branch so that newer dcgm-exporter pod can run without permission issues.
Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
Brought up a cluster using gpu-operator controller image built for this PR. It came up fine and shows no errors.
Without fix:
With fix: