-
Notifications
You must be signed in to change notification settings - Fork 3
CCM-15256: invalid attachment received diagram #280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This aligns with the file-safe.md and file-quarantined.md files, but I've just noticed that most of the other events are in files named -. E.g the uk.nhs.notify.digital.letters.queue.digital.letter.read.v1 event is in a file named queue-digital-letter-read. We also already have print-letter-transitioned.md. Should this file be print-invalid-attachment-received.md? |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| --- | ||
| title: invalid-attachment-received | ||
| type: uk.nhs.notify.digital.letters.print.invalid.attachment.received.v1 | ||
| nice_name: InvalidAttachmentReceived | ||
| service: Print Supplier Services | ||
| schema_envelope: https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/events/uk.nhs.notify.digital.letters.print.invalid.attachment.received.v1.schema.json | ||
| schema_data: https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-print-invalid-attachment-received-data.schema.json | ||
| --- | ||
|
|
||
| This event is published when a digital letter attachment is not in the expected (PDF) format. It indicates that the attachment cannot be processed for printing and requires attention to resolve the issue. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| $schema: https://json-schema.org/draft/2020-12/schema | ||
| title: InvalidAttachmentReceived Data | ||
| description: Data payload of the InvalidAttachmentReceived event | ||
| type: object | ||
| additionalProperties: false | ||
| properties: | ||
| messageReference: | ||
| $ref: ../defs/requests.schema.yaml#/properties/messageReference | ||
| senderId: | ||
| $ref: ../defs/requests.schema.yaml#/properties/senderId | ||
| failureCode: | ||
| $ref: ../defs/requests.schema.yaml#/properties/failureCode | ||
| required: | ||
| - messageReference | ||
| - senderId | ||
| - failureCode |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -62,7 +62,7 @@ properties: | |
| type: string | ||
| description: A codified reason for the status of the message | ||
| examples: | ||
| - "FAILURE001" | ||
| - "DL_CLIV_002" | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changed to a realistic example |
||
| reasonText: | ||
| type: string | ||
| description: Human-readable explanation for the reasonCode | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,4 +36,4 @@ properties: | |
| type: string | ||
| description: The failure code indicating the reason for the message being invalid | ||
| examples: | ||
| - "LOCALID_HEADER_MISSING" | ||
| - "DL_CLIV_001" | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changed to a realistic example |
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| $schema: https://json-schema.org/draft/2020-12/schema | ||
| title: InvalidAttachmentReceived | ||
| type: object | ||
| allOf: | ||
| - $ref: ../digital-letters-print-profile.schema.yaml | ||
| properties: | ||
| type: | ||
| type: string | ||
| const: uk.nhs.notify.digital.letters.print.invalid.attachment.received.v1 | ||
| description: Concrete versioned event type string for this event (.vN suffix). | ||
| source: | ||
| type: string | ||
| pattern: ^/nhs/england/notify/(production|staging|development|uat)/(primary|secondary|dev-[0-9]+)/data-plane/digitalletters/print | ||
| description: Event source for digital letters. | ||
| dataschema: | ||
| type: string | ||
| const: ../data/digital-letters-print-invalid-attachment-received-data.schema.yaml | ||
| description: Canonical URI of the event's data schema. | ||
| examples: | ||
| - digital-letters-print-invalid-attachment-received-data.schema.yaml | ||
| data: | ||
| $ref: ../data/digital-letters-print-invalid-attachment-received-data.schema.yaml |
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this as I'd got the wrong version of ruby and my build didn't work. This seems to be the version we need but wasn't defined here