Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .tool-versions
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ jq 1.6
nodejs 24.10.0
pre-commit 3.6.0
python 3.14.0
ruby 3.2.0
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this as I'd got the wrong version of ruby and my build didn't work. This seems to be the version we need but wasn't defined here

terraform 1.10.1
terraform-docs 0.19.0
vale 3.6.0
Expand Down
50 changes: 26 additions & 24 deletions README.md

Large diffs are not rendered by default.

7 changes: 6 additions & 1 deletion docs/collections/_diagrams/c4code-printer-analyser.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,17 @@ architecture-beta
service analyseLambda(logos:aws-lambda)[PrintAnalyser] in printAnalyser
service safeBucket(logos:aws-s3)[SafeFiles] in printAnalyser
service pdfAnalysed(aws:res-amazon-eventbridge-event)[PDFAnalysed Event]
service invalidAttachment(aws:res-amazon-eventbridge-event)[InvalidAttachmentType Event]
group printAnalyser(cloud)[PrintAnalyser]

junction j1

fileSafe:R --> L:analyseQueue
analyseQueue:R --> L:analyseLambda
safeBucket:B --> T:analyseLambda
analyseLambda:R --> L:pdfAnalysed
analyseLambda:R -- L:j1
j1:T --> B:pdfAnalysed
j1:B --> T:invalidAttachment


```
10 changes: 10 additions & 0 deletions docs/collections/_events/invalid-attachment-received.md
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This aligns with the file-safe.md and file-quarantined.md files, but I've just noticed that most of the other events are in files named -. E.g the uk.nhs.notify.digital.letters.queue.digital.letter.read.v1 event is in a file named queue-digital-letter-read. We also already have print-letter-transitioned.md.

Should this file be print-invalid-attachment-received.md?

Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
---
title: invalid-attachment-received
type: uk.nhs.notify.digital.letters.print.invalid.attachment.received.v1
nice_name: InvalidAttachmentReceived
service: Print Supplier Services
schema_envelope: https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/events/uk.nhs.notify.digital.letters.print.invalid.attachment.received.v1.schema.json
schema_data: https://notify.nhs.uk/cloudevents/schemas/digital-letters/2025-10-draft/data/digital-letters-print-invalid-attachment-received-data.schema.json
---

This event is published when a digital letter attachment is not in the expected (PDF) format. It indicates that the attachment cannot be processed for printing and requires attention to resolve the issue.
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
$schema: https://json-schema.org/draft/2020-12/schema
title: InvalidAttachmentReceived Data
description: Data payload of the InvalidAttachmentReceived event
type: object
additionalProperties: false
properties:
messageReference:
$ref: ../defs/requests.schema.yaml#/properties/messageReference
senderId:
$ref: ../defs/requests.schema.yaml#/properties/senderId
failureCode:
$ref: ../defs/requests.schema.yaml#/properties/failureCode
required:
- messageReference
- senderId
- failureCode
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ properties:
type: string
description: A codified reason for the status of the message
examples:
- "FAILURE001"
- "DL_CLIV_002"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to a realistic example

reasonText:
type: string
description: Human-readable explanation for the reasonCode
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ properties:
type: string
description: The failure code indicating the reason for the message being invalid
examples:
- "LOCALID_HEADER_MISSING"
- "DL_CLIV_001"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to a realistic example

Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
$schema: https://json-schema.org/draft/2020-12/schema
title: InvalidAttachmentReceived
type: object
allOf:
- $ref: ../digital-letters-print-profile.schema.yaml
properties:
type:
type: string
const: uk.nhs.notify.digital.letters.print.invalid.attachment.received.v1
description: Concrete versioned event type string for this event (.vN suffix).
source:
type: string
pattern: ^/nhs/england/notify/(production|staging|development|uat)/(primary|secondary|dev-[0-9]+)/data-plane/digitalletters/print
description: Event source for digital letters.
dataschema:
type: string
const: ../data/digital-letters-print-invalid-attachment-received-data.schema.yaml
description: Canonical URI of the event's data schema.
examples:
- digital-letters-print-invalid-attachment-received-data.schema.yaml
data:
$ref: ../data/digital-letters-print-invalid-attachment-received-data.schema.yaml
116 changes: 63 additions & 53 deletions src/cloudevents/readme-index.yaml

Large diffs are not rendered by default.

Loading