Skip to content

CCM-15256: invalid attachment received diagram#280

Open
tdroza-nhs wants to merge 2 commits intomainfrom
feature/CCM-15256-InvalidAttachmentReceived-diagram
Open

CCM-15256: invalid attachment received diagram#280
tdroza-nhs wants to merge 2 commits intomainfrom
feature/CCM-15256-InvalidAttachmentReceived-diagram

Conversation

@tdroza-nhs
Copy link
Copy Markdown
Contributor

Description

  • Added event schema for InvalidAttachmentReceived
  • Updated PrintAnalyser component diagram to include new event
image

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@tdroza-nhs tdroza-nhs requested a review from a team as a code owner April 9, 2026 15:23
description: A codified reason for the status of the message
examples:
- "FAILURE001"
- "DL_CLIV_002"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to a realistic example

description: The failure code indicating the reason for the message being invalid
examples:
- "LOCALID_HEADER_MISSING"
- "DL_CLIV_001"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to a realistic example

nodejs 24.10.0
pre-commit 3.6.0
python 3.14.0
ruby 3.2.0
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this as I'd got the wrong version of ruby and my build didn't work. This seems to be the version we need but wasn't defined here

@gareth-allan gareth-allan self-assigned this Apr 9, 2026
Copy link
Copy Markdown
Contributor

@gareth-allan gareth-allan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but just one comment about a filename.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This aligns with the file-safe.md and file-quarantined.md files, but I've just noticed that most of the other events are in files named -. E.g the uk.nhs.notify.digital.letters.queue.digital.letter.read.v1 event is in a file named queue-digital-letter-read. We also already have print-letter-transitioned.md.

Should this file be print-invalid-attachment-received.md?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants