Skip to content

Remove a section to make slack alerts more concise #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MatMoore wants to merge 1 commit into from
+1 −22
Closed

Remove a section to make slack alerts more concise #288

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 1 addition & 22 deletions infrastructure/modules/logic-app-slack-alert/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,31 +72,10 @@ resource "azurerm_logic_app_action_custom" "post_to_slack" {
"type": "header",
"text": {
"type": "plain_text",
"text": "@{if(equals(triggerBody()?['data']?['essentials']?['monitorCondition'], 'Resolved'), concat('✅ Resolved – ', triggerBody()?['data']?['essentials']?['alertRule']), concat('🚨 Alert – ', triggerBody()?['data']?['essentials']?['alertRule']))}",
"text": "@{concat(if(equals(triggerBody()?['data']?['essentials']?['monitorCondition'], 'Resolved'), concat('✅ ', triggerBody()?['data']?['essentials']?['severity'], ' resolved'), concat('🚨 ', triggerBody()?['data']?['essentials']?['severity'], ' alert')), ' – ', triggerBody()?['data']?['essentials']?['alertRule'], if(empty(coalesce(triggerBody()?['data']?['essentials']?['configurationItems']?[0], '')), '', concat(' (resource: `', triggerBody()?['data']?['essentials']?['configurationItems']?[0], '`)')))}",
Copy link
Copy Markdown

@malcolmbaig malcolmbaig May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type for the header is plain_text — may need to switch to mrkdwn to get formatting for the backticks used here.

Copy link
Copy Markdown
Author

@MatMoore MatMoore May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep makes sense.

I'm not really happy with this PR as it is though, so going to close it for now as I don't really have the bandwidth to get it into a good state atm. The result is still verbose and it might be better to come up with a new format from scratch.

I think you should be able to see at a glance what the error is about. Ideally I would swap out terraform names like "appi-preprod-uks-manbrs-exceptions-alert" for descriptive text like "high exception rate: manage-breast-screening".

"emoji": true
}
},
{
"type": "section",
"fields": [
{
"type": "mrkdwn",
"text": "@{concat('*Severity*\n', triggerBody()?['data']?['essentials']?['severity'])}"
},
{
"type": "mrkdwn",
"text": "@{concat('*Status*\n', triggerBody()?['data']?['essentials']?['monitorCondition'])}"
},
{
"type": "mrkdwn",
"text": "@{if(equals(triggerBody()?['data']?['essentials']?['monitorCondition'], 'Resolved'), concat('*Resolved At*\n', triggerBody()?['data']?['essentials']?['resolvedDateTime']), concat('*Fired At*\n', triggerBody()?['data']?['essentials']?['firedDateTime']))}"
},
{
"type": "mrkdwn",
"text": "@{concat('*Resource*\n`', coalesce(triggerBody()?['data']?['essentials']?['configurationItems']?[0], 'N/A'), '`')}"
}
]
},
{
"type": "section",
"text": {
Expand Down
Loading