Remove a section to make slack alerts more concise#288
Closed
MatMoore wants to merge 1 commit into
Closed
Conversation
The current alerts take up a lot of vertical space in slack, which means they tend to drown out other messages in the channel. This change moves the resource and severity into the heading, so it will look something like: Sev1 resolved – appi-preprod-uks-manbrs-exceptions-alert (resource: appi-preprod-uks-manbrs) It also drops the fields for Status and Resolved at, since the heading contains whether it is resolved or not, and we have the time the slack message was received at as a proxy for alert times.
malcolmbaig
reviewed
May 11, 2026
| "text": { | ||
| "type": "plain_text", | ||
| "text": "@{if(equals(triggerBody()?['data']?['essentials']?['monitorCondition'], 'Resolved'), concat('✅ Resolved – ', triggerBody()?['data']?['essentials']?['alertRule']), concat('🚨 Alert – ', triggerBody()?['data']?['essentials']?['alertRule']))}", | ||
| "text": "@{concat(if(equals(triggerBody()?['data']?['essentials']?['monitorCondition'], 'Resolved'), concat('✅ ', triggerBody()?['data']?['essentials']?['severity'], ' resolved'), concat('🚨 ', triggerBody()?['data']?['essentials']?['severity'], ' alert')), ' – ', triggerBody()?['data']?['essentials']?['alertRule'], if(empty(coalesce(triggerBody()?['data']?['essentials']?['configurationItems']?[0], '')), '', concat(' (resource: `', triggerBody()?['data']?['essentials']?['configurationItems']?[0], '`)')))}", |
There was a problem hiding this comment.
The type for the header is plain_text — may need to switch to mrkdwn to get formatting for the backticks used here.
Author
There was a problem hiding this comment.
yep makes sense.
I'm not really happy with this PR as it is though, so going to close it for now as I don't really have the bandwidth to get it into a good state atm. The result is still verbose and it might be better to come up with a new format from scratch.
I think you should be able to see at a glance what the error is about. Ideally I would swap out terraform names like "appi-preprod-uks-manbrs-exceptions-alert" for descriptive text like "high exception rate: manage-breast-screening".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change moves the resource and severity fields into the heading, so it will look something like:
✅ Sev1 resolved – appi-preprod-uks-manbrs-exceptions-alert (resource: appi-preprod-uks-manbrs)
It also drops the fields for Status and Resolved at, since the heading already contains whether it is resolved or not, and we have the time the slack message was received at as a proxy for alert times.
Otherwise I've tried to keep all the same sources of information. I did wonder though if we can replace appi-preprod-uks-manbrs-exceptions-alert with a human readable alert name? If we do that maybe the resource part is not neccessary.
We could also maybe hide the description if the alert is resolved, as in that case you only need enough info to identify what's been resolved.
Context
The current alerts take up a lot of vertical space in slack, which means they tend to drown out other messages in the channel and limit the number of messages visible at once.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.