Add thickLine tracers & fix tracers clipping when pointing to things behind player#6173
Open
sophimoo wants to merge 2 commits intoMeteorDevelopment:masterfrom
Open
Add thickLine tracers & fix tracers clipping when pointing to things behind player#6173sophimoo wants to merge 2 commits intoMeteorDevelopment:masterfrom
sophimoo wants to merge 2 commits intoMeteorDevelopment:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
Extends Renderer3D with a new methodthickLinewhich renders lines with configurable widthExtends Renderer3D with
reprojectBehindCamerahelper to project line endpoints behind the camera when they go out of view, preventing them from clipping.Extends Renderer3D withsliderToLinearWidthhelper to convert slider values to actual render widths cuz its actually rly low values 0.001 - 0.01 is the true range anything bigger than 0.01 looks crazy.This PR includes a example usage of the new thickLine replacing line in the blockESP moduleRemoved thickLine stuff cuz it didn't have anti aliasing
It's a bit of a hacky implementation, they're just quads facing the camera, but it seems other clients do this too so 🤷♀️ if it looks good who care
Related issues
Mention any issues that this pr relates to.
How Has This Been Tested?
before
with reprojection fix
Checklist: