feat: add CAIP-19 asset identifiers for each chain into the state #7609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salimtb
changed the title
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
salimtb
force-pushed
the
feat/add-slip44-identfiers-for-added-chains
branch
from
589e726 to
f075c1f
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
packages/network-enablement-controller/src/NetworkEnablementController.ts
Outdated
Show resolved
Hide resolved
sahar-fehri
reviewed
Jan 14, 2026
packages/network-enablement-controller/src/NetworkEnablementController.ts
Show resolved
Hide resolved
packages/network-enablement-controller/src/NetworkEnablementController.ts
Outdated
Show resolved
Hide resolved
packages/network-enablement-controller/src/NetworkEnablementController.ts
Show resolved
Hide resolved
salimtb
changed the title
salimtb
changed the title
salimtb
changed the title
Prithpal-Sooriya
previously approved these changes
Jan 14, 2026
Prithpal-Sooriya
removed this pull request from the merge queue due to a manual request
packages/network-enablement-controller/src/NetworkEnablementController.ts
Outdated
Show resolved
Hide resolved
packages/network-enablement-controller/src/NetworkEnablementController.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Prithpal-Sooriya
approved these changes
Jan 14, 2026
Contributor
Author
|
@metamaskbot publish-preview |
packages/network-enablement-controller/src/NetworkEnablementController.ts
Show resolved
Hide resolved
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
bergarces
reviewed
Jan 14, 2026
| * @param index - The SLIP-44 coin type index (e.g., 60 for ETH, 0 for BTC) | ||
| * @returns The SLIP-44 entry with metadata, or undefined if not found | ||
| */ | ||
| static getSlip44Entry(index: number): Slip44Entry | undefined { |
Contributor
There was a problem hiding this comment.
Is there a use case for this method at the client? I cannot see it being currently used and the parameter name (index) is a bit confusing.
If there are no plans to use it I'd use remove it until it's needed, but otherwise we can rename index to chainId like in getSlip44ByChainId.
Contributor
Author
There was a problem hiding this comment.
i don't need this method anymore , the one we need is the getSlip44ByChainId, i'll remove it in a separated PR now
bergarces
reviewed
Jan 14, 2026
| // Fall back to symbol lookup if provided | ||
| if (symbol) { | ||
| return this.getSlip44BySymbol(symbol); | ||
| } |
Contributor
There was a problem hiding this comment.
There are quite a few entries with repeated symbols in the imported json. This does not look very safe.
LBTC
LKY
LTO
LUM
MONK
MTR
NXT
ONE
PAC
RYO
SAFE
SAMA
SBC
SCR
SUM
TAO
UC
VAL
VARA
XCH
XEC
XRD
Contributor
Author
There was a problem hiding this comment.
i'm actually using this only for non evm ( BTC, SOL, Tron ) , they are unique , for evm the provider https://chainid.network/chains.json is used
Contributor
Author
There was a problem hiding this comment.
so the case of duplicated symbols is handled
Contributor
Author
There was a problem hiding this comment.
maybe i should remove the fallback here , is this your point ?
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 14, 2026
## Explanation The `Slip44Service` was introduced in #7609 to look up SLIP-44 coin types for building native asset identifiers (CAIP-19). However, the initial API had some complexity that wasn't necessary: 1. The `getSlip44ByChainId` method had an optional `symbol` parameter for fallback, but this fallback logic was confusing since EVM networks should use chain ID lookup and non-EVM networks should use symbol lookup - mixing them in one method added unnecessary complexity. 2. The method could return `undefined` for unknown EVM chains, but since EVM networks are all Ethereum-compatible, defaulting to 60 (Ethereum's SLIP-44 coin type) is a reasonable and safe default. 3. The `getSlip44Entry` method and `Slip44Entry` type export weren't being used anywhere. This PR cleans up the service by: - Renaming `getSlip44ByChainId` → `getEvmSlip44` to make it explicit that it's for EVM networks only - Removing the optional `symbol` fallback parameter (use `getSlip44BySymbol` directly for non-EVM networks) - Always returning `60` (Ethereum) as the default for unknown EVM chain IDs instead of `undefined` - Removing the unused `getSlip44Entry` method and `Slip44Entry` type export - Updating the `NetworkEnablementController` to no longer pass the native currency symbol to the lookup function ## References - Follow-up cleanup to #7609 ## Checklist - [x] I've updated the test suite for new or updated code as appropriate - [x] I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate - [x] I've communicated my changes to consumers by [updating changelogs for packages I've changed](https://github.com/MetaMask/core/tree/main/docs/processes/updating-changelogs.md) - [ ] I've introduced [breaking changes](https://github.com/MetaMask/core/tree/main/docs/processes/breaking-changes.md) in this PR and have prepared draft pull requests for clients and consumer packages to resolve them <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Streamlines SLIP-44 resolution and aligns controller usage. > > - Rename `getSlip44ByChainId` → `getEvmSlip44` (EVM-only) and always default to coin type `60` when unmapped > - Remove symbol fallback from EVM lookup; use `getSlip44BySymbol` only for non-EVM networks > - Delete unused `getSlip44Entry` and its type/export; update `services/index.ts` and package `index.ts` exports > - Update `NetworkEnablementController` to call `Slip44Service.getEvmSlip44`, stop passing native currency to add-network handler, and parse references correctly > - Adjust tests to mock/use `getEvmSlip44`, update expectations (e.g., `eip155:2` → `slip44:60`), and remove unused entry tests > - Add changelog entry under "Fixed" for Slip44Service cleanup > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 47cfb4e. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Current State
The
NetworkEnablementControllertracks which networks are enabled/disabled but lacks information about the native asset identifier for each chain. This information is needed to properly identify native assets across different blockchain networks using a standardized format.Extension UI PR: MetaMask/metamask-extension#39234
Solution
This PR adds a new state property
nativeAssetIdentifiersto theNetworkEnablementControllerthat maps CAIP-2 chain IDs to CAIP-19-like native asset identifiers.For example:
eip155:1→eip155:1/slip44:60(Ethereum uses ETH, SLIP-44 coin type 60)eip155:56→eip155:56/slip44:714(BSC uses BNB, SLIP-44 coin type 714)solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp→solana:5eykt4UsFv8P8NJdTREpY1vzqKqZKvdp/slip44:501Implementation Details
New
Slip44Service: A service that wraps the@metamask/slip44package to look up SLIP-44 coin types by symbol (e.g.,ETH→60,BTC→0).State Updates: The
nativeAssetIdentifiersstate is automatically updated when:NetworkController:networkAdded)NetworkController:networkRemoved)NetworkController:stateChange)Default State: Popular networks are pre-populated with their correct native asset identifiers based on their native currency symbols.
Graceful Handling: If a symbol has no SLIP-44 mapping, the entry is removed from the state rather than storing an invalid identifier.
Dependency Addition
Added
@metamask/slip44package to dynamically look up SLIP-44 coin types instead of hardcoding them, ensuring accuracy and maintainability.References
Checklist
Note
Introduces native asset tracking and supporting utilities.
nativeAssetIdentifiersmapping (CAIP-2 ->.../slip44:<coinType>) toNetworkEnablementControllerstate and metadataSlip44Service(uses@metamask/slip44and chainid.network) to resolve coin types by symbol/chainId; exports helpersinit()async and populates EVM identifiers; newinitNativeAssetIdentifiers(networks)API for bulk initialization@metamask/slip44dependencyWritten by Cursor Bugbot for commit f8cdcfc. This will update automatically on new commits. Configure here.